#109183\TYPO3\CMS\Core\Authentication\AuthenticationService::processLoginData returns bool but int is expected
Description
The method \TYPO3\CMS\Core\Authentication\AuthenticationService::processLoginData() returns bool but an int is expected here: \TYPO3\CMS\Core\Authentication\AbstractUserAuthentication::processLoginData because there is this code:
// If the service returns >=200 then no more processing is needed
if ((int)$serviceResult >= 200) {
break;
}Reviews 0
No change resolves or names this issue in its commit message, and no comment links one.
Related issues 1
History 5
-
Simon Schaufelberger commented <span data-processor="relativetime" data-value="2026-03-06T23:09:05+00:00" > 03/06/26, 23:09 </span>
Ok, I only looked at the v13 version where the comment is missing.
Should I just leave it as it is?
What do you think?
-
Markus Klein commented <span data-processor="relativetime" data-value="2026-03-07T12:39:28+00:00" > 03/07/26, 12:39 </span>
I guess it doesn’t make sense to adjust this tiny piece here. We would rather need a rewrite of the Auth-Service structure in general.
The code-magic could be written much nicer nowadays than it was back 15 years ago. -
Georg Ringer commented and changed status
NewClosed priorityShould haveWon't have this time <span data-processor="relativetime" data-value="2026-08-14T07:26:42+00:00" > 08/14/26, 07:26 </span>Hey!
Thanks for creating the issue. Maybe we get something in v15 – see https://forge.typo3.org/issues/110448.I confirm what Markus says, therefore closing the issue – doesn’t make a lot of sense to work on tiny details if the whole thing needs to be redone anyways (no matter if part of v15 or not) – hope this is ok for you!
-
Simon Schaufelberger changed Related to #110448 <span data-processor="relativetime" data-value="2026-08-14T11:56:11+00:00" > 08/14/26, 11:56 </span>
Mind the comment of the function, that explicitly explains the “situation”. It is not nice, but probably breaking to change stuff here.