#109216DatabaseRecordLinkBuilder in some situations builds defect links due to a missing 0-to-null conversion since #102775
Description
For #102775 in https://review.typo3.org/c/Packages/TYPO3.CMS/+/82364/8/typo3/sysext/frontend/Classes/Typolink/DatabaseRecordLinkBuilder.php#85 the check on 0 was converted to a null check because the methods were type-hardened.
So far so good, but on line 80 you set it still to 0, making the null check fail. This leads to defect but still generated links in some cases that previosuly worked as intended (this is: were correctly not generated).
The explicit 0 assignments not coming from a method return must consistently converted to null assignments as well.
Reviews 2
Related issues 2
History 811
-
Garvin Hicking changed category <span data-processor="relativetime" data-value="2026-03-12T10:57:08+00:00" > 03/12/26, 10:57 </span>
-
Benni Mack changed Related to #102775 <span data-processor="relativetime" data-value="2026-03-13T08:35:40+00:00" > 03/13/26, 08:35 </span>
-
Gerrit Code Review pushed patch set 1 for main to change 93612 status
NewUnder Review <span data-processor="relativetime" data-value="2026-04-10T08:44:38+00:00" > 04/10/26, 08:44 </span> -
Benni Mack changed Related to #109671 <span data-processor="relativetime" data-value="2026-04-21T14:35:50+00:00" > 04/21/26, 14:35 </span>
-
Gerrit Code Review pushed patch set 1 for 13.4 to change 93783 <span data-processor="relativetime" data-value="2026-04-21T14:37:39+00:00" > 04/21/26, 14:37 </span>
-
Gerrit Code Review pushed patch set 2 for 13.4 to change 93783 <span data-processor="relativetime" data-value="2026-04-21T14:38:10+00:00" > 04/21/26, 14:38 </span>
-
Georg Ringer commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-04-21T14:40:10+00:00" > 04/21/26, 14:40 </span> -
Benni Mack changed status
ResolvedClosed <span data-processor="relativetime" data-value="2026-08-11T08:46:46+00:00" > 08/11/26, 08:46 </span> -
Benni Mack changed Related to #109380 <span data-processor="relativetime" data-value="2026-10-02T09:25:47+00:00" > 10/02/26, 09:25 </span>
-
Mathias Brodala changed Duplicated by #109380 <span data-processor="relativetime" data-value="2026-10-02T09:41:20+00:00" > 10/02/26, 09:41 </span>
-
Mathias Brodala changed
Related to #109380<span data-processor="relativetime" data-value="2026-10-02T09:41:27+00:00" > 10/02/26, 09:41 </span>
Applied in changeset commit:24aa927a780c2005f7013b19d919c60ab6738346.