#109609PreviewUriBuilder::withRootLine() returns unchanged object
Description
In TYPO3\CMS\Backend\Routing\PreviewUriBuilder the method withRootLine() returns an unchanged object.
/**
* @param array $rootLine (alternative) root-line of pages
* @return static
*/
public function withRootLine(array $rootLine): self
{
if ($this->rootLine === $rootLine) {
return $this;
}
$target = clone $this;
$target->rootLine = $rootLine;
return $this;
}
Instead of
return $this;
this should be returned
return $target;Reviews 2
History 35
-
Thomas Kühnel commented 04/16/26, 16:15
-
Gerrit Code Review pushed patch set 1 for main to change 93699 status
NewUnder Review 04/16/26, 19:38 -
Gerrit Code Review pushed patch set 1 for 13.4 to change 93711 04/17/26, 11:04
-
Georg Ringer commented and changed status
Under ReviewResolved done0 %100 % 04/17/26, 11:10Applied in changeset commit:39290a9fe7ca51747ea9b9df539741d41a8acf09.
-
Benni Mack changed status
ResolvedClosed 04/21/26, 11:30
To be more precise: Instead of
this should be returned