#109770Playwright helper middleware authenticates requests
Description
The playwright middleware added with the migrated install tool
tests in #109761 raised concerns since the test instance is
exposed as local port.
The patch adds a secret available to the middleware and
playwright sent as HTTP header and verified in the middleware.
Reviews 3
Related issues 1
History 412
-
Christian Kuhn changed Related to #109761 <span data-processor="relativetime" data-value="2026-05-05T09:54:45+00:00" > 05/05/26, 09:54 </span>
-
Gerrit Code Review pushed patch set 1 for main to change 93984 status
NewUnder Review <span data-processor="relativetime" data-value="2026-05-05T10:00:54+00:00" > 05/05/26, 10:00 </span> -
Christian Kuhn commented and changed status
Under ReviewRejected <span data-processor="relativetime" data-value="2026-06-18T23:00:29+00:00" > 06/18/26, 23:00 </span> -
Garvin Hicking commented and changed description status
RejectedAccepted <span data-processor="relativetime" data-value="2026-06-26T10:14:07+00:00" > 06/26/26, 10:14 </span>Re-opening the patch – we talked about this patch in the merger round today, and thoughts were raised that the issue itself needs to be resolved.
We figured it would be acceptable to re-use this issue, but then push a new patch with different ownership (to not impersonate) but similar code. I hope that is fine, otherwise I’ll take the blame :-)
-
Gerrit Code Review pushed patch set 1 for main to change 94592 status
AcceptedUnder Review <span data-processor="relativetime" data-value="2026-06-26T10:18:45+00:00" > 06/26/26, 10:18 </span> -
Gerrit Code Review pushed patch set 2 for main to change 94592 <span data-processor="relativetime" data-value="2026-06-26T11:48:57+00:00" > 06/26/26, 11:48 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 94592 <span data-processor="relativetime" data-value="2026-06-26T16:33:33+00:00" > 06/26/26, 16:33 </span>
-
Gerrit Code Review pushed patch set 4 for main to change 94592 <span data-processor="relativetime" data-value="2026-07-20T11:21:25+00:00" > 07/20/26, 11:21 </span>
-
Gerrit Code Review pushed patch set 5 for main to change 94592 <span data-processor="relativetime" data-value="2026-07-29T05:30:44+00:00" > 07/29/26, 05:30 </span>
-
Gerrit Code Review pushed patch set 1 for 14.3 to change 94977 <span data-processor="relativetime" data-value="2026-07-29T07:27:08+00:00" > 07/29/26, 07:27 </span>
-
Gerrit Code Review pushed patch set 2 for 14.3 to change 94977 <span data-processor="relativetime" data-value="2026-07-29T07:27:43+00:00" > 07/29/26, 07:27 </span>
-
Garvin Hicking commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-07-29T07:40:12+00:00" > 07/29/26, 07:40 </span>Applied in changeset commit:9b5c870c9042c989baacc77b8ff5c12ba7b6374a.
abandoned, probably not gonna happen.