Issue Task Resolved

#109770Playwright helper middleware authenticates requests

Christian Kuhn 05/05/26, 09:54 updated 07/29/26, 07:40

Description

The playwright middleware added with the migrated install tool
tests in #109761 raised concerns since the test instance is
exposed as local port.

The patch adds a secret available to the middleware and
playwright sent as HTTP header and verified in the middleware.

Reviews 3

History 412

  1. Christian Kuhn commented and changed status Under Review Rejected <span data-processor="relativetime" data-value="2026-06-18T23:00:29+00:00" > 06/18/26, 23:00 </span>

    abandoned, probably not gonna happen.

  2. Garvin Hicking commented and changed description status Rejected Accepted <span data-processor="relativetime" data-value="2026-06-26T10:14:07+00:00" > 06/26/26, 10:14 </span>

    Re-opening the patch – we talked about this patch in the merger round today, and thoughts were raised that the issue itself needs to be resolved.

    We figured it would be acceptable to re-use this issue, but then push a new patch with different ownership (to not impersonate) but similar code. I hope that is fine, otherwise I’ll take the blame :-)

  3. Gerrit Code Review pushed patch set 1 for main to change 94592 status Accepted Under Review <span data-processor="relativetime" data-value="2026-06-26T10:18:45+00:00" > 06/26/26, 10:18 </span>

  4. Garvin Hicking commented and changed status Under Review Resolved done 0 % 100 % <span data-processor="relativetime" data-value="2026-07-29T07:40:12+00:00" > 07/29/26, 07:40 </span>

    Applied in changeset commit:9b5c870c9042c989baacc77b8ff5c12ba7b6374a.