#109810Merge settings.definitions from siteset dependencies
Description
Follow up to #109809
The settings from a site sets dependencies settings.definitions.yaml seems to not be taken into account when create SettingDefinition.
This makes it “not possible” to override a single setting of a site set dependencies settings, without defining the whole settings
So, instead being able to write
settings:
felogin.Pid:
hidden: true
I must write the full definition with all known properties
settings:
felogin.Pid:
type: Page
hidden: true
Suggestion goes towards merging the settings.definitions of dependencies
Reviews 0
No change resolves or names this issue in its commit message, and no comment links one.
Fix this issue
Start the commit message of your patch with this. Add what the patch does, and the versions it goes to in "Releases:". How to create a patch
- Commit message
-
[BUGFIX] Merge settings.definitions from siteset dependencies Resolves: #109810 Releases: main
Related issues 1
History 3
-
Benjamin Franzke commented <span data-processor="relativetime" data-value="2026-05-11T08:47:00+00:00" > 05/11/26, 08:47 </span>
-
Soren Malling commented <span data-processor="relativetime" data-value="2026-05-12T07:51:49+00:00" > 05/12/26, 07:51 </span>
Benjamin Franzke wrote in #note-1:
> The question instead is:
> What do you want to achieve? I guess you want to hide the setting from the editing interface, maybe because you prefilled it with a value?Different cases:
- EXT:news has a setting for preview – we use the value of the detail pid. So the setting has no effect and only “disturbs” the settings. Hide it
- Settings with a already set value that should not be overridden
-
Soren Malling changed Related to #109809 <span data-processor="relativetime" data-value="2026-05-13T06:58:52+00:00" > 05/13/26, 06:58 </span>
Individual settings are not merged, since otherwise we’d need to introduce constructs to delete existing settings, define when things are appended and when merged and so on.
So this is basically a balance between ease-of-overwriting vs unexpected-surprises.
Actually even overwriting is not a good practice and we should instead clarify
We merge settings and even allow to overwrite existing ones (which we probably should have forbidden, because existing usages can rely on the given definition), but the setting definition for one setting is sealed and has to be overwritten as one entity.
The question instead is:
What do you want to achieve? I guess you want to hide the setting from the editing interface, maybe because you prefilled it with a value?