Issue Task Resolved

#110109ModifyPageLinkConfigurationEvent does not include request

Helmut Hummel 06/26/26, 08:54 updated 06/29/26, 07:30

Description

The signature of

public function buildLink(array $linkDetails, array $configuration, ServerRequestInterface $request, string $linkText = ''): LinkResultInterface

includes a required request, but this request is not passed to ModifyPageLinkConfigurationEvent which is emitted in this method.

If a request could be required to build a link as annotated in the interface, it should be propagated to listeners,
that need to modify the link.

Reviews 3

History 311

  1. Gerrit Code Review pushed patch set 1 for main to change 94591 status New Under Review 06/26/26, 08:57

  2. Gerrit Code Review pushed patch set 2 for main to change 94591 06/26/26, 11:45

  3. Benjamin Franzke changed tracker Bug Task 06/26/26, 11:45

  4. Gerrit Code Review pushed patch set 1 for 14.3 to change 94599 06/26/26, 13:11

  5. Gerrit Code Review pushed patch set 1 for 13.4 to change 94600 06/26/26, 13:12

  6. Gerrit Code Review pushed patch set 2 for 13.4 to change 94600 06/26/26, 13:13

  7. Gerrit Code Review pushed patch set 2 for 14.3 to change 94599 06/27/26, 07:37

  8. Gerrit Code Review pushed patch set 3 for 13.4 to change 94600 06/27/26, 07:38

  9. Helmut Hummel commented and changed status Under Review Resolved done 0 % 100 % 06/27/26, 07:40

    Applied in changeset commit:414ad58c26d9dae008bb04662af4d7cebd51a23c.

  10. Gerrit Code Review pushed patch set 4 for 13.4 to change 94600 status Resolved Under Review 06/29/26, 06:55

  11. Helmut Hummel commented and changed status Under Review Resolved 06/29/26, 07:30

    Applied in changeset commit:bc90be0d638fb35503c92246c718644f5c634be7.