#110289Cleanup some leftover remarks for older PHP versions
Description
- Update TreeNodeCollection::asort() from bool plus #[ReturnTypeWillChange] to the native-compatible true return type; remove its obsolete TODO.
- In DateTimeFactory, catch only DateMalformedStringException; PHP 8.3+ no longer requires the generic Exception fallback.
- Replace value-only $array[array_key_first(…)] and $array[array_key_last(…)] expressions with array_first() and array_last(). Preserve calls where the key itself is required or assigned.
- Fix remaining stale PHP-version guidance, notably the PHP 8.3 example in runTests.sh, and make the lazy reaction documentation example readonly, now supported by Symfony’s native PHP lazy objects.
Reviews 1
History 14
-
Gerrit Code Review pushed patch set 1 for main to change 94936 status
NewUnder Review <span data-processor="relativetime" data-value="2026-07-24T19:49:18+00:00" > 07/24/26, 19:49 </span> -
Gerrit Code Review pushed patch set 2 for main to change 94936 <span data-processor="relativetime" data-value="2026-07-24T19:50:29+00:00" > 07/24/26, 19:50 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 94936 <span data-processor="relativetime" data-value="2026-07-24T20:05:02+00:00" > 07/24/26, 20:05 </span>
-
Wouter Wolters commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-07-25T12:35:09+00:00" > 07/25/26, 12:35 </span>
Applied in changeset commit:43f36437cb0c180c7256ad6d4fffc549f868d14c.