#110413Explicit algo is not defined in certain places
Description
Commit e1830d8d966 ([!!!][TASK] Use stronger cryptographic algorithm for HMAC) moved FileDumpController::isTokenValid() and ResourceStorage::getPublicUrl() to SHA3-256, but missed two token generators:
- typo3/sysext/fluid/Classes/ViewHelpers/Link/FileViewHelper.php:130
- typo3/sysext/form/Classes/Slot/ResourcePublicationSlot.php:84
Both still call hmac(…, ‘resourceStorageDumpFile’) without the algo argument, so they emit SHA-1 tokens that the controller rejects — f:link.file on a non-public storage should be returning 403 on main. T
Reviews 2
History 13
-
Gerrit Code Review pushed patch set 1 for main to change 95213 status
NewUnder Review <span data-processor="relativetime" data-value="2026-08-10T17:03:19+00:00" > 08/10/26, 17:03 </span> -
Gerrit Code Review pushed patch set 1 for 14.3 to change 95219 <span data-processor="relativetime" data-value="2026-08-10T20:10:07+00:00" > 08/10/26, 20:10 </span>
-
Benni Mack commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-08-10T20:15:09+00:00" > 08/10/26, 20:15 </span>
Applied in changeset commit:044f74f700ccd70f0e861e67d135fb07c2824e94.