Issue Task Resolved

#110804Remove clock and random-value flakiness from tests

Wouter Wolters 09/26/26, 15:33 updated 09/28/26, 19:25

Description

Several tests depend on timing or random values:

CronCommandTest can cross a minute boundary between constructing the command and reading the clock.
NonceTest and RequestTokenTest use random time offsets where fixed timestamps suffice.
ResetPasswordControllerTest asserts a real delay of at least 200 ms, which is unreliable under varying test load.

Use clock readings around object creation and fixed representative timestamps. Remove the wall-clock delay assertion while leaving the password-reset delay itself unchanged.

Reviews 2

History 13

  1. Gerrit Code Review pushed patch set 1 for main to change 96103 status New Under Review 09/26/26, 15:37

  2. Gerrit Code Review pushed patch set 1 for 14.3 to change 96136 09/28/26, 19:05

  3. Wouter Wolters commented and changed status Under Review Resolved done 0 % 100 % 09/28/26, 19:25

    Applied in changeset commit:fd0f576bb81fcf20ca5ff9319410bfaf7a2c1db9.