Issue Task Resolved

#110834Correct authentication log parameter types

Wouter Wolters 09/29/26, 15:50 updated 09/30/26, 05:40

Description

The AuthenticationService::writeLogMessage() PHPDoc describes each variadic
formatting argument as an array. Its callers pass strings, and vsprintf()
expects formatting values rather than arrays. The incorrect annotation causes
a PHPStan finding suppressed in the baseline.

Reviews 2

History 16

  1. Gerrit Code Review pushed patch set 1 for main to change 96164 status New Under Review 09/29/26, 15:55

  2. Gerrit Code Review pushed patch set 2 for main to change 96164 09/29/26, 16:15

  3. Gerrit Code Review pushed patch set 3 for main to change 96164 09/29/26, 16:25

  4. Gerrit Code Review pushed patch set 4 for main to change 96164 09/29/26, 16:59

  5. Gerrit Code Review pushed patch set 1 for 14.3 to change 96192 09/30/26, 05:37

  6. Wouter Wolters commented and changed status Under Review Resolved done 0 % 100 % 09/30/26, 05:40

    Applied in changeset commit:d3d4067dde5e142ac433d2b7ffae913a333be811.