Issue Task Resolved

#110838Correct schema migrator selection parameter type

Wouter Wolters 09/29/26, 16:02 updated 09/30/26, 12:40

Description

SchemaMigrator::migrate() documents selected statements as a list of hashes,
but it selects statements using the array keys. Its callers pass arrays keyed
by statement hash. The inaccurate PHPDoc causes a PHPStan finding in
@PackageSetup@ that is suppressed in the baseline.

Reviews 2

History 15

  1. Gerrit Code Review pushed patch set 1 for main to change 96168 status New Under Review 09/29/26, 16:06

  2. Gerrit Code Review pushed patch set 2 for main to change 96168 09/30/26, 10:42

  3. Gerrit Code Review pushed patch set 1 for 14.3 to change 96218 09/30/26, 12:33

  4. Gerrit Code Review pushed patch set 2 for 14.3 to change 96218 09/30/26, 12:34

  5. Wouter Wolters commented and changed status Under Review Resolved done 0 % 100 % 09/30/26, 12:40

    Applied in changeset commit:684635c8e9eba05f2e61d2ea9a4f510205ed74d8.