#18499Typo in t3lib/thumbs.php causes eternally lasting gm processes to slow down server.
Description
Affects all versions.
Steps to reproduce problem:
- setup a TYPO3 with GraphicsMagick
- Upload a file with a space in the name
- go to the fileadmin
- try to generate a thumbnail
- watch the output of a: ps ax on the console
For an unknown (to me at least) reason the ‘convert -sample’ command in t3lib/thumbs.php states:
$parameters = ‘-sample ‘.$this->size.’ ‘.$colors.’ ‘.$this->wrapFileName($this->input.’0‘).’ ‘.$this->wrapFileName($this->output);
Where this should read:
$parameters = ‘-sample ‘.$this->size.’ ‘.$colors.’ ‘.$this->wrapFileName($this->input).’ ‘.$this->wrapFileName($this->output);
Note the ommission of .’0‘ . . . It is unclear to me why it is there . . .
It causes the call to wrapFileName ‘not’ to wrap a filename with spaces and thus spawns a faulty gm conversion command (unquoted filename with spaces) which hangs around on the server in the process queue untill killed manually.
I cannot find any reference to a [0] in any documentation on ImageMagick / GraphicsMagich and thus think this is a typo.
Removing .0 from the code results in happy thumbnail generation.
(issue imported from #M7938)
Reviews 0
No change resolves or names this issue in its commit message, and no comment links one.