#22896cannot integrate a constant into <INCLUDE_TYPOSCRIPT: source=/fileadmin/{$myconstant}
Description
cannot integrate a constant into a path in TS-Setup while using
<INCLUDE_TYPOSCRIPT: source=/fileadmin/{$myconstant} . . .
would be nice if this works as it is interesting feature in multidomaintrees
(issue imported from #M14744)
Reviews 0
No change resolves or names this issue in its commit message, and no comment links one.
Related issues 1
History 26
Show 1 earlier messages
-
Paul Voss commented 07/06/10, 17:31
-
Steffen Gebert commented 07/26/10, 08:22
+1
would also like this very much! d.ross or Paul, are you able to create a patch? -
Fedir RYKHTIK commented 11/28/10, 23:58
Hi there,
it could be very handy suche feature.
Looks like, what need to patch function checkIncludeLines in t3lib/class.t3lib_tsparser.php.The code is some old, so it’s not so easy to understand the logic. Normally, need to add regexp, which will preparse and substitue the TS constants.
If anybody could indicate the documentation about TS parsing (checking constants etc), probably, could take care about this feature.
Regards,
Fedir -
Alexander Opitz commented and changed status
NewNeeds Feedback target version 06/11/13, 18:17As this report is very old, is the handling in newer TYPO3 CMS Versions (like 6.0/6.1) more like you expect it?
-
d.ros no-lastname-given commented 06/11/13, 18:24
Untested but afaik it doesn´t work in 6.1 either
-
Alexander Opitz changed status
Needs FeedbackNew 07/11/13, 12:23 -
Alexander Opitz changed category 07/11/13, 12:23
-
Stefan Neufeind commented and changed status
NewRejected 10/15/13, 10:14In #47985 Thorsten Kahler explained:
This behaviour is documented, see http://docs.typo3.org/typo3cms/TyposcriptSyntaxReference/Syntax/Includes/Index.html
Reason: The final TS constants tree can’t be used before all includes are resolved, so this is kind of a hen and egg problem. Otherwise includes could not be used for constants. -
Franz Holzinger commented 10/15/13, 10:52
The issue request has been about the include statements inside of a setup. This could be realized for the setup only. Includes for constants could be disallowed for this enhanced feature.
-
d.ros no-lastname-given commented 10/15/13, 10:57
Franz is correct. Inside setup would be sufficient as you can deliver the fixed constants file by extension, while TS path needs to be flexible.
Cheers
David
-
Jigal van Hemert commented and changed status
RejectedNeeds Feedback priorityShould haveCould have 10/17/13, 16:46It could be done for Setup only, but it requires quite some changes in the processing. Substitution of constants must be done twice, once for includes second time for “normal” constant substitutions. Handling of includes must be done in two steps.
It will most likely take extra processing time, this has to be taken into account.I personally doubt the extra value of this feature. Now that it’s possible to include entire directories (recursively, only certain file extensions), it’s easier to change the includes without touching the actual <include command itself.
Can someone give a use case which cannot be solved by the include directory directive?
-
Alexander Opitz commented 05/23/14, 09:08
Can someone give a use case which cannot be solved by the include directory directive?
If there won’t be any response in 3 months, the issue will be closed.
-
d.ros no-lastname-given commented 05/23/14, 09:18
> I personally doubt the extra value of this feature. Now that it’s possible to include entire directories (recursively, only certain file extensions), it’s easier to change the includes without touching the actual <include command itself.
The usecase remains the same.
If you have a multidomaintree where you want to divide the branches from each other you would go with an automatic include path for ts like this -> “fileadmin/usecase/{$BRANCHNAME}/scripts/ts”
So in the end this option is still handy if it would be there.
> It will most likely take extra processing time, this has to be taken into account.
But AFAIK only once until it is cached?
-
d.ros no-lastname-given commented 05/23/14, 09:30
> Can someone give a use case which cannot be solved by the include directory directive?
Other way round asked: How would you divide a multidomaintree with branches in fileadmin with the automatic include option -without touching the path?
-
Alexander Opitz changed status
Needs FeedbackNew 05/26/14, 11:12 -
Mathias Schreiber changed assigned to Mathias Schreiber 12/14/14, 09:45
-
Susanne Moog changed Sprint Focus PRC 08/07/15, 10:32
-
Mathias Schreiber commented 08/07/15, 10:56
Is there a particular reason you do not store your templating information in an extension?
-
d.ros no-lastname-given commented 08/07/15, 12:14
Quite simple: There must not be an extension.
A lot of people setup systems without any provider extensions for ts only.Cheers
-
Björn Jacob commented 08/07/15, 13:13
Even if you use an extension for providing the whole site package it would still make sense to have such a feature. The constant could carry the extension name/ name of the site package and all the additional includes don’t need any manipulation/ further changes and could be re-used.
The directory inclusion is IMHO not enough since you cannot tell the system the sort/ load order of the files, can you?
-
Mathias Schreiber commented 08/07/15, 13:17
phew… I gotta be honest here.
I never needed this in 15 years and yes, I have done tons of multi-tree sites.
Effectively doubling the rendering times of TS in the frontend just for this?
I have a hard time telling myself that punishing all users with a massive performance implication doesn’t quite convince me yet.I’m totally up for discussion, don’t get me wrong but right now the pros don’t outweigh the cons.
-
Björn Jacob commented 08/07/15, 13:27
I still like the idea from an integrator’s point of view. But making the whole process significantly slower is not worth the effort. I don’t get the use case for multi domain setups.
-
d.ros no-lastname-given commented 08/07/15, 13:51
The usecase is that if you setup multiple sites in one tree with completely differing setups you cannot have a preconfigured tree which can be setup by drag and drop plus adding a single constant to assign the paths for all relating files. You have to manipulate every regarding field manually. The related fields are userTS, TSsetup, and so on.
But in the end if this really twices the rendering the onthought solution isn’t the best. Perhaps there’s another possiblity to provide relative setting paths.
-
Mathias Schreiber commented 08/07/15, 13:56
d.ros no-lastname-given wrote:
> multiple sites in one treeIs this a typo?
Otherwise I need a lot more info on what you try to achieve :) -
Riccardo De Contardi commented and changed status
NewClosed removed the assignee 06/08/18, 22:39Three years has passed without a real advancement on this issue; therefore I close this one for now.
TYPO3 team is working on a working towards an easier concept to create sites and their configuration from inside the backend, without the performance penalty of this solution; if it will be necessary, fresh issues will be opened about this topic.
If you think that this is the wrong decision, please ping me and I’ll reopen it.
-
Benni Mack changed Sprint Focus
PRCNeeds Decision 03/24/20, 17:52
Would really like to see this feature, too. Makes setting up new projects (with similar fileadmin structures) much faster.