Issue Feature Closed

#34624Changing the type field of a new element should not result in saving

Nico de Haen 03/07/12, 08:12 updated 04/20/25, 14:37

Description

This is really an old gremlin, but I couldn’t find an issue related to that.
Changing the type field of a new element should not result in saving that element.

This is for 3 reasons:
1. There is no validation (possible) since the required fields of a certain type may be not visible in the other types configuration
2. If you click on “Cancel” instead of “Ok” you will have a mixed form: the type field selector shows the new type but the form is still displayed with the old types configuration
3. For usability reasons any dataset should only be saved when an editor clicks the save button

As you probably know this behaviour is almost as old as TYPO3, maybe we can get rid of it in 6.0? ;-)

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.

History 11

  1. Riccardo De Contardi commented <span data-processor="relativetime" data-value="2018-10-28T18:17:42+00:00" > 10/28/18, 18:17 </span>

    It still comes true for the latest master.

    Quick way to test it:

    1) create a content element, type: text – write “test” as headline
    2) Save it
    3) Change the CType into “table” (for example)

    the modal shows the message:

    This change will affect which fields are available in the form. Would you like to save now in order to refresh the display?

    4) click on “Cancel” instead of ok

    Results

    - the CType field still shows “Table“
    - but the remaining backend form is still the one for the “text” element

  2. Riccardo De Contardi commented and changed status New Needs Feedback <span data-processor="relativetime" data-value="2019-01-29T22:29:02+00:00" > 01/29/19, 22:29 </span>

    About this issue, on a second thought I don’t know if it can be considered valid anymore (maybe not):

    In fact, since TYPO3 7.6 if you perform the points 1-4 of my previous comment:

    1) create a content element, type: text – write “test” as headline
    2) Save it
    3) Change the CType into “table” (for example)
    4) click on “Cancel” instead of “Ok”

    You will end with a “mixed” form where the CType field still shows “Table” , and the remaining backend form is still the one for the “text” element; but the form *is not saved*
    If you try to close it, another modal tells you that there are unsaved properties and asks you a confirm (save or discard)

    Do you think that it is sufficient to consider this issue solved? Thank you!

  3. Susanne Moog commented and changed status Needs Feedback Accepted <span data-processor="relativetime" data-value="2020-03-24T11:18:23+00:00" > 03/24/20, 11:18 </span>

    @Riccardo: I don’t think so, I think the problem is:

    If you have a required field in a content element and you create a new element where that required field is displayed -> change the type without filling the field -> click “save” in the modal for reloading —> you now have a saved element where you did not fill in the required field.

  4. Georg Ringer commented and changed status Accepted Closed <span data-processor="relativetime" data-value="2025-04-20T14:37:09+00:00" > 04/20/25, 14:37 </span>

    Hey,

    As already stated in the beginning, this issue is as old as TYPO3 as this is the behavior of Formengine + DataHandler and how people are used to work with TYPO3. changing this would mean a rewrite to e.g. a PWA or similiar. Not that I say that this is not doable, there is no roadmap for that and therefore I am closing this issue