Issue Bug Rejected

#35253Installer should respect backticks while creating sql queries

Kay Strobach 03/26/12, 23:47 updated 11/27/15, 18:09

Description

The TYPO3 SQL parser removes backticks from table and field names in SQL statements. This causes errors.

E.g. a valid SQL file entry like this (with backticks):

CREATE TABLE `user_piwikintegration_site` (
  `group` varchar(250) NOT NULL,
) TYPE=InnoDB  AUTO_INCREMENT=2 ;

is converted to this invalid SQL (without backticks):

CREATE TABLE user_piwikintegration_site ( group varchar(250) NOT NULL ) ENGINE=InnoDB;

While the first query is valid, the modified query causes an error:

Error:
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'group varchar(250) NOT NULL' at line 2

The Problem can be easily fixed, by editing t3lib_install::getUpdateSuggestions in t3lib/class.t3lib_install.php

Todo:
  • add backticks around table names
  • add backticks around fieldnames

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.