Issue Bug Rejected

#50871Remove option to delete a File Storage

Frans Saris 08/07/13, 13:55 updated 01/10/25, 09:39

Description

Currently it doesn’t make sense you can delete a storage.
When you delete a storage there is no check if there are still files in uses of this storage.
So everywhere where a reference to a sys_file of the deleted storage is present you get a Exception.

Reviews 3

History 1214

  1. Oliver Hader commented <span data-processor="relativetime" data-value="2013-08-07T14:36:12+00:00" > 08/07/13, 14:36 </span>

    If we see a storage as a definition to connect a folder of the physical file system with the TYPO3 file abstraction layer, then we still might allow to remove the storage definition, however should catch the exceptions – or add an option to the install tool to remove a storage, it’s sys_file records (not the actual files), sys_file_references and processed files.

  2. Andreas Wolf commented and changed status New Accepted Is Regression 0 <span data-processor="relativetime" data-value="2014-06-20T11:06:16+00:00" > 06/20/14, 11:06 </span>

    I just had this case while debugging a broken installation. I think the DataMapper should check in a hook that no files are still in use from that storage (or we disallow deletion completely if that’s possible).

  3. Alexander Opitz commented <span data-processor="relativetime" data-value="2015-01-30T10:15:38+00:00" > 01/30/15, 10:15 </span>

    I think, we should left the possibility to delete storages, for example if you moved from a local to a remote storage (or vice versa). Maybe first we need to define scenarios.

    But maybe this scenarios lead to a “FAL Management Extension” which is more for admins and not editors (like media).

  4. Philipp Gampe commented <span data-processor="relativetime" data-value="2015-01-30T10:40:25+00:00" > 01/30/15, 10:40 </span>

    I also think that deleting orphaned storages should be possible.

  5. Gerrit Code Review changed status In Progress Under Review <span data-processor="relativetime" data-value="2015-01-30T18:25:13+00:00" > 01/30/15, 18:25 </span> Patch set 1 for branch *master* of project *Packages/TYPO3.CMS* has been pushed to the review server. It is available at http://review.typo3.org/36456

  6. Gerrit Code Review <span data-processor="relativetime" data-value="2015-01-31T14:17:03+00:00" > 01/31/15, 14:17 </span> Patch set 2 for branch *master* of project *Packages/TYPO3.CMS* has been pushed to the review server. It is available at http://review.typo3.org/36456

  7. Philipp Gampe commented and changed category status Under Review Accepted <span data-processor="relativetime" data-value="2015-01-31T15:49:01+00:00" > 01/31/15, 15:49 </span>

    The solution here is to deny deletion of any record which is still referenced.

    This would also solve #55714

  8. Anja Leichsenring changed Sprint Focus On Location Sprint Remote Sprint <span data-processor="relativetime" data-value="2015-08-10T08:02:01+00:00" > 08/10/15, 08:02 </span>

  9. Georg Ringer commented and changed status New Rejected <span data-processor="relativetime" data-value="2025-01-10T09:39:16+00:00" > 01/10/25, 09:39 </span>

    I am closing this issue. this is admin only and even editors can “destroy” the site by removing the wrong stuff, e.g. disabling the root page.

    having some basic checks is not helpful at all because there could be relations to file from content elements which are located on a deleted page or on a not available page(-tree).

    if there are exceptions in frontend because the storage itself is removed, this need be be fixed but deleting the storage record should always be possible