#61234Copy plus FAL in workspace bug
Description
Recently there have been similar bugs identified and fixed in the core. This one takes specific steps to trigger.
1) Create an image CE in the live workspace
2) Go to a custom workspace
3) Open the CE, delete its image (image #1) and add image #2
4) On preview you see what you expect (image #2)
5) While still in the workspace and before publishing, copy the CE.
6) The original CE will be fine, but the copy will have 2 images (image #1 and image #2)
7) I think on copy in the workspace it is not accounting the possibility of the FAL record being deleted in the workspace.
Reviews 6
- 12.4 87238[BUGFIX] Avoid copying workspace delete placeholder
- 13.4 87237[BUGFIX] Avoid copying workspace delete placeholder
- main 87235[BUGFIX] Avoid copying workspace delete placeholder
- 12.4 87233[TASK] Add another image to DataScenarios/FAL tests
- 13.4 87232[TASK] Add another image to DataScenarios/FAL tests
- main 87231[TASK] Add another image to DataScenarios/FAL tests
Related issues 1
Files 1
History 1522
-
Mathias Schreiber changed target version <span data-processor="relativetime" data-value="2015-01-23T11:33:56+00:00" > 01/23/15, 11:33 </span>
-
Oliver Hader commented and changed status
NewNeeds Feedback target version Complexity medium <span data-processor="relativetime" data-value="2015-09-24T10:50:43+00:00" > 09/24/15, 10:50 </span> -
Oliver Hader commented and changed attached image.png status
Needs FeedbackAccepted priorityMust haveShould have <span data-processor="relativetime" data-value="2015-10-30T16:34:50+00:00" > 10/30/15, 16:34 </span>The issue with duplicated images is gone, however the delete placeholder was remove on copying the content element. This results in the deleted image being active again.
-
Oliver Hader changed target version <span data-processor="relativetime" data-value="2015-10-30T16:35:12+00:00" > 10/30/15, 16:35 </span>
-
Mathias Schreiber changed target version <span data-processor="relativetime" data-value="2015-11-12T17:15:30+00:00" > 11/12/15, 17:15 </span>
-
Riccardo De Contardi commented <span data-processor="relativetime" data-value="2020-09-26T21:20:17+00:00" > 09/26/20, 21:20 </span>
As far as I can see this issue (including the duplicated image) is still reproducible on 11.0.0-dev (latest master).
-
Benni Mack changed Sprint Focus Stabilization Sprint <span data-processor="relativetime" data-value="2023-06-06T13:02:02+00:00" > 06/06/23, 13:02 </span>
-
Riccardo De Contardi commented <span data-processor="relativetime" data-value="2024-06-06T13:04:19+00:00" > 06/06/24, 13:04 </span>
This issue is still reproducible on 13.2.0-dev (latest main)
-
Garvin Hicking changed TYPO3 Version
6.213 PHP Version5.58.3 Tags Workspace-fal fal <span data-processor="relativetime" data-value="2024-06-06T18:38:56+00:00" > 06/06/24, 18:38 </span> -
Benni Mack commented <span data-processor="relativetime" data-value="2024-10-07T14:27:20+00:00" > 10/07/24, 14:27 </span>
What a nasty bug! Reproduceable – and we need proper tests.
-
Christian Kuhn changed Related to #105698 <span data-processor="relativetime" data-value="2024-11-26T00:09:51+00:00" > 11/26/24, 00:09 </span>
-
Simon Schaufelberger changed description <span data-processor="relativetime" data-value="2024-11-26T12:40:36+00:00" > 11/26/24, 12:40 </span>
-
Gerrit Code Review pushed patch set 1 for main to change 87235 status
AcceptedUnder Review <span data-processor="relativetime" data-value="2024-11-26T13:32:47+00:00" > 11/26/24, 13:32 </span> -
Christian Kuhn commented <span data-processor="relativetime" data-value="2024-11-26T13:37:16+00:00" > 11/26/24, 13:37 </span>
patch set 1 comes with a test to verify this is an issue.
-
Gerrit Code Review pushed patch set 2 for main to change 87235 <span data-processor="relativetime" data-value="2024-11-26T14:09:59+00:00" > 11/26/24, 14:09 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 87235 <span data-processor="relativetime" data-value="2024-11-26T14:14:16+00:00" > 11/26/24, 14:14 </span>
-
Gerrit Code Review pushed patch set 4 for main to change 87235 <span data-processor="relativetime" data-value="2024-11-26T15:00:17+00:00" > 11/26/24, 15:00 </span>
-
Gerrit Code Review pushed patch set 5 for main to change 87235 <span data-processor="relativetime" data-value="2024-11-26T15:07:16+00:00" > 11/26/24, 15:07 </span>
-
Gerrit Code Review pushed patch set 1 for 13.4 to change 87237 <span data-processor="relativetime" data-value="2024-11-26T15:16:55+00:00" > 11/26/24, 15:16 </span>
-
Gerrit Code Review pushed patch set 1 for 12.4 to change 87238 <span data-processor="relativetime" data-value="2024-11-26T15:47:44+00:00" > 11/26/24, 15:47 </span>
-
Christian Kuhn commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2024-11-26T17:05:08+00:00" > 11/26/24, 17:05 </span>Applied in changeset commit:c5502c089ace5d2425ac3e187e07b0caab2fb842.
-
Benni Mack changed status
ResolvedClosed <span data-processor="relativetime" data-value="2025-12-02T14:36:43+00:00" > 12/02/25, 14:36 </span>
Might be fixed with some of the recent workspace placeholder fixes for TYPO3 CMS 7.5 and 6.2.16