Issue Bug Closed

#66616Double encoding in tag builder

Jan Kiesewetter 04/28/15, 08:33 updated 06/30/16, 11:31

Description

The tag builder uses htmlspecialchars to encode values of attributes. The problem is, that if I give in a value from the database containing " it will be double html encoded because htmlspecialchars just called without some parameters.

https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/typo3/sysext/fluid/Classes/Core/ViewHelper/TagBuilder.php#l174

My suggestion would be

htmlspecialchars($attributeValue, ENT_QUOTES, 'UTF-8', FALSE);

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.