Issue Bug Closed

#66813Persisting extbase FileReference does not work with default TCA configuration

Philipp Kerling 05/06/15, 10:04 updated 02/27/26, 09:47

Description

I try to programatically create a sys_file_reference in a field of a custom domain object in an extbase FE plugin.

This is the code I use:

/* @var $coverImage \TYPO3\CMS\Extbase\Domain\Model\FileReference */
$coverImage = $this->objectManager->get('TYPO3\CMS\Extbase\Domain\Model\FileReference');
$imageReference = $this->resourceFactory->createFileReferenceObject(array(
    'uid_local' => $imageFile->getUid(),
    'uid_foreign' => \uniqid('NEW_'),
    'uid' => \uniqid('NEW_')
));
$coverImage->setOriginalResource($imageReference);
$object->setCoverImage($coverImage);

Sadly, this does not work, as the fields “tablenames” and “table_local” in the sys_file_reference will be empty.

The cover_image field is defined in the TCA as follows:

'cover_image' => array(
    'exclude' => 1,
    'label' => 'LLL:EXT:openimmo_import/Resources/Private/Language/locallang_db.xlf:tx_openimmoimport_domain_model_realestateobject.cover_image',
    'config' => \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::getFileFieldTCAConfig(
        'coverImage',
        array(
            'maxitems' => 1
        ),
        $GLOBALS['TYPO3_CONF_VARS']['GFX']['imagefile_ext']
    ),
),

As you can see, it uses the standard recommended function getFileFieldTCAConfig to generate the field definition.

Now it does work if you add “tablenames” and “table_local” to “foreign_match_fields”, like this:

    'config' => \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::getFileFieldTCAConfig(
        'coverImage',
        array(
            'maxitems' => 1,
            'foreign_match_fields' => array(
            'tablenames' => 'tx_openimmoimport_domain_model_realestateobject',
            'table_local' => 'sys_file'
            )
        ),
        $GLOBALS['TYPO3_CONF_VARS']['GFX']['imagefile_ext']
    ),

This is also how the upload_example extension does it: https://github.com/helhum/upload_example/blob/master/Configuration/TCA/tx_uploadexample_domain_model_example.php#L136

Is this intended? If it is, why doesn’t getFileFieldTCAConfig do it like this by default?

Reviews 1

History 819

  1. Wouter Wolters commented and changed status New Closed <span data-processor="relativetime" data-value="2015-05-06T18:45:14+00:00" > 05/06/15, 18:45 </span>

    Hi Philipp,

    This not the right place to ask questions. This a bugtracker. Please use the Mailinglist/Forum for questions.
    Forum can be found at https://forum.typo3.org/

    I will close this ticket to keep the bugtracker clean.

  2. Helmut Hummel commented and changed status Closed Accepted Complexity hard <span data-processor="relativetime" data-value="2015-05-07T11:47:36+00:00" > 05/07/15, 11:47 </span>

    This is an inconsistency, which is worth tackling. However, I’m not sure
    yet whether we should do son in the TCA helper method or in Extbase
    peristence …

    I

  3. Philipp Kerling commented <span data-processor="relativetime" data-value="2015-05-10T09:48:11+00:00" > 05/10/15, 09:48 </span>

    I’ve noticed that at least ‘tablenames’ does seem to get set when the domain model uses an ObjetStorage for multiple FAL references. ‘table_local’ is still empty.

    So I’d say fix it in Extbase, since the TCA should be OK the way it is.
    • ‘tablenames’ can be inferred from TCA ‘foreign_table_field’ which is correctly set. This needs to get fixed in Extbase when persisting properties that are a single FileReference (those properties currently have some other problems, but I’ll file separate bug reports for that)
    • ‘table_local’ should (always) be set to ‘sys_file’ because that is the default value for the column given in the ‘sys_file_reference’ TCA.
  4. Gerrit Code Review pushed patch set 1 for main to change 78166 status Accepted Under Review <span data-processor="relativetime" data-value="2023-03-17T23:40:40+00:00" > 03/17/23, 23:40 </span>

  5. Stefan Froemken commented and changed status Under Review Closed assigned to Stefan Froemken <span data-processor="relativetime" data-value="2023-06-26T10:12:22+00:00" > 06/26/23, 10:12 </span>

    Hello Philipp,

    thank you for providing this issue to us.
    I have just tried to test that issue in TYPO3 12.4.2 and can not reproduce it anymore.

    Here are some annotations regarding your ticket:
    • Setting uid_foreign AND uid_to a random value is not the way to go
    • getFileFieldTCAConfig is replaced by type = ‘file’
    • tablename will be set automatically now
    • table_local has been removed

    IMO this problem is solved now.

    I will close the ticket now. If you feel this is the wrong decision, let me know, and I will re-open it.

    Stefan

  6. Gerrit Code Review pushed patch set 3 for main to change 78166 status Closed Under Review <span data-processor="relativetime" data-value="2024-07-14T21:14:58+00:00" > 07/14/24, 21:14 </span>