#79014DataHandler not deleting inline and MM references if base table does not have a "delete"-field leads to DatabaseRecordException
Description
DataHandler calls deleteRecord_procFields() to check and delete inline and MM references only if the base table has a “delete”-field:
if ($deleteField && !$forceHardDelete) {
...
// before (un-)deleting this record, check for child records or references
$this->deleteRecord_procFields($table, $uid, $undeleteRecord);
$this->databaseConnection->exec_UPDATEquery($table, 'uid=' . (int)$uid, $updateFields);
// Delete all l10n records as well, impossible during undelete because it might bring too many records back to life
if (!$undeleteRecord) {
$this->deleteL10nOverlayRecords($table, $uid);
}
} else {
...
// Delete the hard way...:
$this->databaseConnection->exec_DELETEquery($table, 'uid=' . (int)$uid);
$this->deleteL10nOverlayRecords($table, $uid);
}
This is wrong. If a table does not contain a defined “delete”-field in TCA and has inline or MM-relations and a record from this table is deleted, the related and mm records stay in the database.
If you try to open the record on the other side of the mm-relation you get a @DatabaseRecordException@ with @#1437656081: Record with uid XXX from table tx_extension_mytable@ not found because the relation in the mm table is still there but the record is not.
Reviews 6
- 13.4 89617[BUGFIX] Correctly hard-delete inline foreign field children
- main 89614[BUGFIX] Correctly hard-delete inline foreign field children
- 13.4 89585[BUGFIX] Delete relations of tables without delete-field
- main 50987[BUGFIX] Delete relations of tables without delete-field
- 13.4 89520[BUGFIX] Improve recycler hard delete DB consistency
- main 89497[BUGFIX] Improve recycler hard delete DB consistency
Related issues 4
- Bug #76138Inline Relations - Delete Behaviour with mixed Usage of the Deleted Flag
- Bug #81549Deleting categories in trash bin does not delete mm records
- Bug #95541Strange behavior of DataHandler regarding hard- and flag-delete with enableCascadingDelete
- Bug #106815Correctly hard-delete inline foreign field children
History 939
Show 414 earlier messages
-
Stephan Großberndt changed status
NewIn Progress assigned to Stephan Großberndt <span data-processor="relativetime" data-value="2016-12-16T12:14:18+00:00" > 12/16/16, 12:14 </span> -
Gerrit Code Review pushed patch set 1 for master to change 50987 status
In ProgressUnder Review <span data-processor="relativetime" data-value="2016-12-16T12:25:09+00:00" > 12/16/16, 12:25 </span> -
Gerrit Code Review pushed patch set 2 for master to change 50987 <span data-processor="relativetime" data-value="2016-12-16T12:52:41+00:00" > 12/16/16, 12:52 </span>
-
Stephan Großberndt commented <span data-processor="relativetime" data-value="2018-03-02T11:21:07+00:00" > 03/02/18, 11:21 </span>
-
Gerrit Code Review pushed patch set 3 for master to change 50987 <span data-processor="relativetime" data-value="2018-10-27T17:25:28+00:00" > 10/27/18, 17:25 </span>
-
Gerrit Code Review pushed patch set 4 for master to change 50987 <span data-processor="relativetime" data-value="2019-02-18T10:09:09+00:00" > 02/18/19, 10:09 </span>
-
Gerrit Code Review pushed patch set 5 for master to change 50987 <span data-processor="relativetime" data-value="2019-02-18T10:10:50+00:00" > 02/18/19, 10:10 </span>
-
Gerrit Code Review pushed patch set 6 for master to change 50987 <span data-processor="relativetime" data-value="2019-02-18T12:21:36+00:00" > 02/18/19, 12:21 </span>
-
Gerrit Code Review pushed patch set 7 for master to change 50987 <span data-processor="relativetime" data-value="2019-02-18T12:51:52+00:00" > 02/18/19, 12:51 </span>
-
Gerrit Code Review pushed patch set 8 for master to change 50987 <span data-processor="relativetime" data-value="2019-03-17T18:53:59+00:00" > 03/17/19, 18:53 </span>
-
Markus Klein changed Duplicated by #22535 <span data-processor="relativetime" data-value="2019-08-01T10:59:51+00:00" > 08/01/19, 10:59 </span>
-
Markus Klein changed Related to #76138 <span data-processor="relativetime" data-value="2019-08-01T22:13:23+00:00" > 08/01/19, 22:13 </span>
-
Gerrit Code Review pushed patch set 9 for master to change 50987 <span data-processor="relativetime" data-value="2019-11-09T17:20:52+00:00" > 11/09/19, 17:20 </span>
-
Gerrit Code Review pushed patch set 10 for master to change 50987 <span data-processor="relativetime" data-value="2019-11-09T18:32:07+00:00" > 11/09/19, 18:32 </span>
-
Gerrit Code Review pushed patch set 11 for master to change 50987 <span data-processor="relativetime" data-value="2020-05-25T20:46:33+00:00" > 05/25/20, 20:46 </span>
-
Gerrit Code Review pushed patch set 13 for master to change 50987 <span data-processor="relativetime" data-value="2021-11-18T10:37:12+00:00" > 11/18/21, 10:37 </span>
-
Gerrit Code Review pushed patch set 14 for main to change 50987 <span data-processor="relativetime" data-value="2021-11-29T14:08:29+00:00" > 11/29/21, 14:08 </span>
-
Gerrit Code Review pushed patch set 15 for main to change 50987 <span data-processor="relativetime" data-value="2023-05-03T09:30:59+00:00" > 05/03/23, 09:30 </span>
-
Gerrit Code Review pushed patch set 16 for main to change 50987 <span data-processor="relativetime" data-value="2024-10-18T13:49:56+00:00" > 10/18/24, 13:49 </span>
-
Gerrit Code Review pushed patch set 17 for main to change 50987 <span data-processor="relativetime" data-value="2025-04-16T14:17:06+00:00" > 04/16/25, 14:17 </span>
-
Gerrit Code Review pushed patch set 18 for main to change 50987 <span data-processor="relativetime" data-value="2025-04-16T14:34:39+00:00" > 04/16/25, 14:34 </span>
-
Christian Kuhn changed Related to #81549 <span data-processor="relativetime" data-value="2025-05-22T15:30:02+00:00" > 05/22/25, 15:30 </span>
-
Gerrit Code Review pushed patch set 19 for main to change 50987 <span data-processor="relativetime" data-value="2025-05-27T16:27:44+00:00" > 05/27/25, 16:27 </span>
-
Gerrit Code Review pushed patch set 20 for main to change 50987 <span data-processor="relativetime" data-value="2025-05-28T09:15:26+00:00" > 05/28/25, 09:15 </span>
-
Gerrit Code Review pushed patch set 21 for main to change 50987 <span data-processor="relativetime" data-value="2025-05-28T09:57:26+00:00" > 05/28/25, 09:57 </span>
-
Gerrit Code Review pushed patch set 22 for main to change 50987 <span data-processor="relativetime" data-value="2025-05-28T10:14:35+00:00" > 05/28/25, 10:14 </span>
-
Gerrit Code Review pushed patch set 23 for main to change 50987 <span data-processor="relativetime" data-value="2025-05-28T10:36:42+00:00" > 05/28/25, 10:36 </span>
-
Gerrit Code Review pushed patch set 24 for main to change 50987 <span data-processor="relativetime" data-value="2025-05-28T10:39:29+00:00" > 05/28/25, 10:39 </span>
-
Gerrit Code Review pushed patch set 25 for main to change 50987 <span data-processor="relativetime" data-value="2025-05-28T10:45:37+00:00" > 05/28/25, 10:45 </span>
-
Gerrit Code Review pushed patch set 26 for main to change 50987 <span data-processor="relativetime" data-value="2025-05-28T10:49:37+00:00" > 05/28/25, 10:49 </span>
-
Gerrit Code Review pushed patch set 27 for main to change 50987 <span data-processor="relativetime" data-value="2025-05-28T12:04:28+00:00" > 05/28/25, 12:04 </span>
-
Gerrit Code Review pushed patch set 28 for main to change 50987 <span data-processor="relativetime" data-value="2025-05-28T13:59:14+00:00" > 05/28/25, 13:59 </span>
-
Gerrit Code Review pushed patch set 29 for main to change 50987 <span data-processor="relativetime" data-value="2025-05-28T15:27:21+00:00" > 05/28/25, 15:27 </span>
-
Gerrit Code Review pushed patch set 30 for main to change 50987 <span data-processor="relativetime" data-value="2025-05-28T15:33:38+00:00" > 05/28/25, 15:33 </span>
-
Gerrit Code Review pushed patch set 1 for 13.4 to change 89585 <span data-processor="relativetime" data-value="2025-05-28T16:41:41+00:00" > 05/28/25, 16:41 </span>
-
Stephan Großberndt commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2025-05-28T16:55:09+00:00" > 05/28/25, 16:55 </span>Applied in changeset commit:3b10a3ca18630b34771054da85c40807f306621e.
-
Christian Kuhn changed Related to #106815 <span data-processor="relativetime" data-value="2025-06-03T14:45:31+00:00" > 06/03/25, 14:45 </span>
-
Benni Mack changed status
ResolvedClosed <span data-processor="relativetime" data-value="2025-12-02T14:36:43+00:00" > 12/02/25, 14:36 </span> -
Benni Mack changed Related to #95541 <span data-processor="relativetime" data-value="2026-11-09T08:21:50+00:00" > 11/09/26, 08:21 </span>
Configuration/TCA/tx_blogexample_domain_model_blog.php
<?php return [ 'ctrl' => [ 'title' => 'blog', 'label' => 'title' ], 'interface' => [ 'showRecordFieldList' => 'title, posts' ], 'columns' => [ 'title' => [ 'label' => 'title', 'config' => [ 'type' => 'input' ] ], 'posts' => [ 'label' => 'posts', 'config' => [ 'type' => 'inline', 'foreign_table' => 'tx_blogexample_domain_model_post', 'foreign_field' => 'blog' ] ], ], 'types' => [ '1' => ['showitem' => 'title, posts'] ] ];Configuration/TCA/tx_blogexample_domain_model_post.php
<?php return [ 'ctrl' => [ 'title' => 'post', 'label' => 'title' ], 'interface' => [ 'showRecordFieldList' => 'title, blog' ], 'columns' => [ 'title' => [ 'label' => 'title', 'config' => [ 'type' => 'input' ] ], 'blog' => [ 'label' => 'blog', 'config' => [ 'type' => 'select', 'renderType' => 'selectSingle', 'foreign_table' => 'tx_blogexample_domain_model_blog', 'maxitems' => 1 ] ], ], 'types' => [ '1' => ['showitem' => 'title, blog'] ] ];ext_tables.sql
CREATE TABLE tx_blogexample_domain_model_blog ( uid int(11) unsigned DEFAULT '0' NOT NULL auto_increment, pid int(11) DEFAULT '0' NOT NULL, deleted tinyint(4) unsigned DEFAULT '0' NOT NULL, title varchar(255) DEFAULT '' NOT NULL, posts varchar(255) DEFAULT '' NOT NULL, PRIMARY KEY (uid), KEY parent (pid) ); CREATE TABLE tx_blogexample_domain_model_post ( uid int(11) unsigned DEFAULT '0' NOT NULL auto_increment, pid int(11) DEFAULT '0' NOT NULL, deleted tinyint(4) unsigned DEFAULT '0' NOT NULL, blog int(11) DEFAULT '0' NOT NULL, title varchar(255) DEFAULT '' NOT NULL, PRIMARY KEY (uid), KEY parent (pid) );If
'delete' => 'deleted',is defined inConfiguration/TCA/tx_blogexample_domain_model_post.php:$TCA['ctrl']and you delete the blog the related posts will get deleted=1, if its not defined, nothing happens to them. (I typed this up from memory without re-testing..)