Issue Bug Closed

#79269Condition in ResourceCompressor::retrieveExternalFile makes no sense

David Greiner 01/11/17, 10:53 updated 10/02/18, 11:04

Description

Hi!

Trying to compress and concatenate external assets leads to an error. This happens because condition in ResourceCompressor::retrieveExternalFile:637-648 makes no sense.

if (!file_exists(PATH_site . $filename)
            && (md5($externalContent) !== md5(file_get_contents(PATH_site . $filename)))
        ) {
            GeneralUtility::writeFile(PATH_site . $filename, $externalContent);
        }

It is not possible to “file_get_contents” a file that not exists.

May be the following is a better condition:

 if (!file_exists(PATH_site . $filename) ||
            (file_exists(PATH_site . $filename) && md5($externalContent) !== md5(file_get_contents(PATH_site . $filename)))) {
            GeneralUtility::writeFile(PATH_site . $filename, $externalContent);
        }

Reviews 2