Issue Bug Closed

#79314Outdated PHPDoc comment in AbstractTreeView

Stefan Rotsch 01/13/17, 16:40 updated 10/02/18, 11:04

Description

While making an old extension work in TYPO3 7.6 and 8, I found that behavior of the AbstractTreeView has changed between 7.6.

The description of the variable $makeHTML is outdated, as it describes a configuration option no longer existing:

    /**
     * If TRUE, HTML code is also accumulated in ->tree array during rendering of the tree.
     * If 2, then also the icon prefix code (depthData) is stored
     *
     * @var int
     */
    public $makeHTML = 1;

The variable is treated as a boolean since 7.6, the mentioned value of “2” does not have any effect, so the affected line should be removed.

Ideally, the variable should be converted to a boolean. But as it’s a public variable, I assume this would be considered a breaking change, so please let me know if I should provide a patch set for that, too.

Reviews 1