Issue Bug Closed

#79569IRRE preview does not show a default icon when no preview rendering is possible

Daniel Wagner 01/31/17, 12:45 updated 07/08/24, 18:13

Description

*Scenario*
A user adds a CE upload (“File Links”) to a page and adds e.g. some files with extension .xls and .pdf.

*Problem*
The preview rendered within IRRE does not work for all allowed fileextensions – see attachment.
The thumbnail rendering of PDF is working correctly in module filelist – see attachment.

  • although thumbnail generation for PDF is working a default icon shown – that is okay.
  • for XLS a preview does not make sense but is tried and no icon is shown – that looks odd.

*Versions*
TYPO3 CMS 7.6.15

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.

Files 6

History 6

  1. Daniel Wagner changed attached ce_filelist_pagemodule.png 01/31/17, 16:31

  2. Daniel Wagner changed attached preview_1e8552bd43.gif.png 02/07/17, 12:58

  3. Daniel Wagner commented 02/07/17, 13:15

    *Thumbnail Rendering*
    renderForeignRecordHeader in InlineRecordContainer.php lets the image tool render a preview
    and then will show the thumbnail if the processedImage has any width otherwise an icon will be shown.

    In my case graphicsmagick renders a gif-thumbnail containing some text infos which has a width :(

    *Suggestion*
    Instead checking the thumbnail generation afterwards there should be a check against [GFX][imagefile_ext] before the generation.

    Side Effects
    • there wont be any PDF thumbnail if you do not allow PDFs as image (as suggested by TYPO3)
    • in matters of security it is better to render only images (there have been issues in the past, e.g. TYPO3-PSA-2016-001)
  4. Daniel Wagner changed category Tags image security backend irre Complexity easy 02/08/17, 08:20

  5. Susanne Moog changed category 10/26/17, 15:50

  6. Georg Ringer commented and changed attached Bildschirmfoto 2024-07-08 um 20.11.54.png attached Bildschirmfoto 2024-07-08 um 20.12.50.png status New Closed 07/08/24, 18:13

    this looks nicer now since a long time, therefore closing

    !Bildschirmfoto%202024-07-08%20um%2020.11.54.png!
    Bildschirmfoto%202024-07-08%20um%2020.12.50.png