Issue Bug Closed

#82060File Abstraction Layer: Extract metadata in storage (scheduler) failing on indexing files that matches denied patterns(['BE']['fileDenyPattern'])

Ricky Mathew 08/09/17, 11:50 updated 10/02/18, 10:59

Description

File Abstraction Layer: Extract metadata in storage (scheduler) fails on trying to index the files in denied pattern([‘BE’][‘fileDenyPattern’]) by throwing an exception like following::
_
_TYPO3\CMS\Core\Resource\Exception\InsufficientFileAccessPermissionsExceptionprototypeobject
message => ‘You are not allowed to access that file: “browserdetect.inc.php”’ (64 chars)
code => 1375955429 (integer)__

And my [‘BE’][‘fileDenyPattern’] is “\.(php[3-7]?|phpsh|phtml)(\..*)?$|^\.htaccess$”

We can avoid this by just adding a condition check in runMetaDataExtraction() function in TYPO3\CMS\Core\Resource\Index\Indexer class as follows

$isAllowed = GeneralUtility::verifyFilenameAgainstDenyPattern($indexRecord['name']);

           if($isAllowed){
            $fileObject = $this->getResourceFactory()->getFileObject($indexRecord['uid'], $indexRecord);
            $this->extractMetaData($fileObject);
           }

so can any one please provide a patch with above mentioned solution?

Reviews 3