Issue Bug Rejected

#85965FileWriter fails to check for valid log file path

Sebastian Michaelsen 08/24/18, 16:43 updated 08/25/18, 14:52

Description

\TYPO3\CMS\Core\Log\Writer\FileWriter::setLogFile() uses GeneralUtility::getFileAbsFileName() to get the absolute path to a given $logFile. GeneralUtility::getFileAbsFileName() always returns a string, even in an error case it returns an empty string. However the return value is checked for being null.

https://github.com/TYPO3/TYPO3.CMS/commit/bfdc332650a92839e8ae73ec21b29f23609b5a1e#r30280568

That means that exception #1444374805 can never be thrown.

This applies to v7, v8 and master.

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.