Issue Task Closed

#87394composer gerrit:setup should be available for all platforms

Sybille Peters 01/11/19, 08:51 updated 03/24/20, 19:05

Description

I am currently updating the Contribution Guide. I would like to simplify the setup.

composer gerrit:setup sets up both commit hooks: commit-msg and pre-commit. The pre-commit hook currently may not run on Windows.

For this reason, you can’t just write: just run composer gerrit:setup to setup commit hooks. You have to write: for windows do …, for Linux / Mac do …

So, it might be useful to do one of the following:

  1. make the pre-commit hook portable
  2. only copy the commit-msg hook with gerrit:setup
  3. or check before copying if it will run on current system in InstallerScripts:enablePreCommitHook

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.