#88886DataMapper: Consider languageOverlayMode "hideNonTranslated" when getting relations using consistentTranslationOverlayHandling
Description
The language overlay handling doesn’t work properly using the new “consistentTranslationOverlayHandling” when getting DB relations if the language overlay mode is “hideNonTranslated” (fallbackType: strict).
Problem:
At the moment the languageOverlayMode is always set to true as
> we always want to overlay relations as most of the time they are stored in db using default lang uids
That’s correct. However, if the configured language overlay mode is “hideNonTranslated” (fallbackType: strict), we need to consider this.
Otherwise, if there’s no translation, the default relation/row isn’t removed in sysext/frontend/Classes/Page/PageRepository.php:790 (v9) resp. sysext/core/Classes/Domain/Repository/PageRepository.php:628 (v10) (called by $pageRepository->getRecordOverlay() in Typo3DbBackend::overlayLanguageAndWorkspace).
Solution:
1. Consider “hideNonTranslated” already when creating the parent object’s query, so it can be passed to the sub query later on.
sysext/extbase/Classes/Persistence/Generic/Backend.php:
275 275 public function getObjectByIdentifier($identifier, $className)
276 276 {
277 277 if ($this->session->hasIdentifier($identifier, $className)) {
278 278 return $this->session->getObjectByIdentifier($identifier, $className);
279 279 }
280 280 $query = $this->persistenceManager->createQueryForType($className);
281 281 $query->getQuerySettings()->setRespectStoragePage(false);
282 282 $query->getQuerySettings()->setRespectSysLanguage(false);
283 - $query->getQuerySettings()->setLanguageOverlayMode(true);
283 + if ($query->getQuerySettings()->getLanguageOverlayMode() !== 'hideNonTranslated') {
284 + $query->getQuerySettings()->setLanguageOverlayMode(true);
285 + }
284 286 return $query->matching($query->equals('uid', $identifier))->execute()->getFirst();
285 287 }
2. Pass “hideNonTranslated” to sub query.
sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php:
456 456 if ($this->configurationManager->isFeatureEnabled('consistentTranslationOverlayHandling')) {
457 457 //we always want to overlay relations as most of the time they are stored in db using default lang uids
458 458 $query->getQuerySettings()->setLanguageOverlayMode(true);
459 459 if ($this->query) {
460 460 $query->getQuerySettings()->setLanguageUid($this->query->getQuerySettings()->getLanguageUid());
461 + if ($this->query->getQuerySettings()->getLanguageOverlayMode() === 'hideNonTranslated') {
462 + $query->getQuerySettings()->setLanguageOverlayMode('hideNonTranslated');
463 + }
461 464
462 465 if ($dataMap->getLanguageIdColumnName() !== null && !$this->query->getQuerySettings()->getRespectSysLanguage()) {Reviews 2
Related issues 5
- Bug #82363Make Extbase translation handling consistent with typoscript
- Bug #89131Records that are only available in specific language (no default parent) are not considered using consistentTranslationOverlayHandling
- Feature #97926Use LanguageAspect in Extbase Persistence
- Bug #110025ObjectStorage->contains not working anymore with overlays off
- Bug #110498sys_file_reference value of sys_language_uid is assigned with a value of 0 in a translated model if the referenced sys_file has been used by a base language object
History 1443
Show 818 earlier messages
-
Matthias Meusburger commented <span data-processor="relativetime" data-value="2019-08-02T08:57:46+00:00" > 08/02/19, 08:57 </span>
-
Matthias Meusburger commented <span data-processor="relativetime" data-value="2019-08-22T18:36:04+00:00" > 08/22/19, 18:36 </span>
An example to illustrate the problem:
We have a product with 5 referenced features (multiselect via MM table, l10n_mode=exclude).
Only 4 of those 5 features are localized e.g. into German.Without this fix the 5th unlocalized feature would also be there (in default language) although having set fallbackType=“strict” (hideNonTranslated).
With the fix there will be only 4 features in German (as expected with “hideNonTranslated”). -
Matthias Meusburger changed category <span data-processor="relativetime" data-value="2019-09-10T11:10:13+00:00" > 09/10/19, 11:10 </span>
-
Matthias Meusburger changed subject
DataMapper: Consider languageOverlayMode "hideNonTranslated" when getting relationsDataMapper: Consider languageOverlayMode "hideNonTranslated" when getting relations using consistentTranslationOverlayHandling <span data-processor="relativetime" data-value="2019-09-10T11:27:19+00:00" > 09/10/19, 11:27 </span> -
Matthias Meusburger changed Duplicated by #89132 <span data-processor="relativetime" data-value="2019-09-10T16:49:16+00:00" > 09/10/19, 16:49 </span>
-
Mathias Brodala changed Related to #89131 <span data-processor="relativetime" data-value="2020-11-13T12:05:48+00:00" > 11/13/20, 12:05 </span>
-
Mathias Brodala changed Related to #82363 <span data-processor="relativetime" data-value="2020-11-18T10:59:07+00:00" > 11/18/20, 10:59 </span>
-
Gerrit Code Review pushed patch set 1 for master to change 66694 status
NewUnder Review <span data-processor="relativetime" data-value="2020-11-18T11:20:14+00:00" > 11/18/20, 11:20 </span> -
Gerrit Code Review pushed patch set 2 for master to change 66694 <span data-processor="relativetime" data-value="2020-11-18T14:12:40+00:00" > 11/18/20, 14:12 </span>
-
Gerrit Code Review pushed patch set 3 for master to change 66694 <span data-processor="relativetime" data-value="2020-11-18T14:41:33+00:00" > 11/18/20, 14:41 </span>
-
Gerrit Code Review pushed patch set 4 for master to change 66694 <span data-processor="relativetime" data-value="2020-11-18T15:04:17+00:00" > 11/18/20, 15:04 </span>
-
Gerrit Code Review pushed patch set 5 for master to change 66694 <span data-processor="relativetime" data-value="2020-11-18T15:25:53+00:00" > 11/18/20, 15:25 </span>
-
Gerrit Code Review pushed patch set 6 for master to change 66694 <span data-processor="relativetime" data-value="2020-11-18T15:34:18+00:00" > 11/18/20, 15:34 </span>
-
Mathias Brodala changed Is Regression 1 <span data-processor="relativetime" data-value="2020-11-18T16:40:06+00:00" > 11/18/20, 16:40 </span>
-
Gerrit Code Review pushed patch set 7 for master to change 66694 <span data-processor="relativetime" data-value="2020-11-19T07:41:40+00:00" > 11/19/20, 07:41 </span>
-
Gerrit Code Review pushed patch set 8 for master to change 66694 <span data-processor="relativetime" data-value="2020-11-19T08:41:36+00:00" > 11/19/20, 08:41 </span>
-
Gerrit Code Review pushed patch set 9 for master to change 66694 <span data-processor="relativetime" data-value="2020-11-19T09:40:30+00:00" > 11/19/20, 09:40 </span>
-
Gerrit Code Review pushed patch set 10 for master to change 66694 <span data-processor="relativetime" data-value="2020-11-19T10:08:26+00:00" > 11/19/20, 10:08 </span>
-
Gerrit Code Review pushed patch set 11 for master to change 66694 <span data-processor="relativetime" data-value="2020-11-19T10:35:38+00:00" > 11/19/20, 10:35 </span>
-
Gerrit Code Review pushed patch set 12 for master to change 66694 <span data-processor="relativetime" data-value="2021-02-05T08:16:30+00:00" > 02/05/21, 08:16 </span>
-
Gerrit Code Review pushed patch set 13 for master to change 66694 <span data-processor="relativetime" data-value="2021-05-21T15:19:15+00:00" > 05/21/21, 15:19 </span>
-
Gerrit Code Review pushed patch set 14 for master to change 66694 <span data-processor="relativetime" data-value="2021-08-05T15:31:06+00:00" > 08/05/21, 15:31 </span>
-
Alexander Vogt commented <span data-processor="relativetime" data-value="2021-08-06T09:35:32+00:00" > 08/06/21, 09:35 </span>
We have the same issue (TYPO3 9 / 10). Currently we use the following workaround via the “ModifyQueryBeforeFetchingObjectDataEvent” event:
class ModifyQueryBeforeFetchingObjectDataListener { public function __invoke(ModifyQueryBeforeFetchingObjectDataEvent $event): void { $parentQuery = $event->getQuery()->getParentQuery(); if(empty($parentQuery)) { return; } $event->getQuery()->getQuerySettings()->setLanguageOverlayMode('hideNonTranslated'); } } -
Gerrit Code Review pushed patch set 15 for master to change 66694 <span data-processor="relativetime" data-value="2021-09-22T14:41:30+00:00" > 09/22/21, 14:41 </span>
-
Gerrit Code Review pushed patch set 16 for main to change 66694 <span data-processor="relativetime" data-value="2021-11-29T13:28:30+00:00" > 11/29/21, 13:28 </span>
-
Mathias Brodala changed Related to #97926 <span data-processor="relativetime" data-value="2024-05-21T10:32:11+00:00" > 05/21/24, 10:32 </span>
-
Gerrit Code Review pushed patch set 17 for main to change 66694 <span data-processor="relativetime" data-value="2024-05-21T10:32:18+00:00" > 05/21/24, 10:32 </span>
-
Gerrit Code Review pushed patch set 18 for main to change 66694 <span data-processor="relativetime" data-value="2024-05-21T12:34:37+00:00" > 05/21/24, 12:34 </span>
-
Gerrit Code Review pushed patch set 19 for main to change 66694 <span data-processor="relativetime" data-value="2024-10-18T13:30:58+00:00" > 10/18/24, 13:30 </span>
-
Gerrit Code Review pushed patch set 20 for main to change 66694 <span data-processor="relativetime" data-value="2026-02-06T09:02:57+00:00" > 02/06/26, 09:02 </span>
-
Gerrit Code Review pushed patch set 21 for main to change 66694 <span data-processor="relativetime" data-value="2026-02-08T09:39:30+00:00" > 02/08/26, 09:39 </span>
-
Gerrit Code Review pushed patch set 22 for main to change 66694 <span data-processor="relativetime" data-value="2026-02-26T10:58:18+00:00" > 02/26/26, 10:58 </span>
-
Gerrit Code Review pushed patch set 23 for main to change 66694 <span data-processor="relativetime" data-value="2026-03-04T15:49:05+00:00" > 03/04/26, 15:49 </span>
-
Gerrit Code Review pushed patch set 24 for main to change 66694 <span data-processor="relativetime" data-value="2026-06-07T18:52:27+00:00" > 06/07/26, 18:52 </span>
-
Gerrit Code Review pushed patch set 25 for main to change 66694 <span data-processor="relativetime" data-value="2026-07-15T15:08:27+00:00" > 07/15/26, 15:08 </span>
-
Gerrit Code Review pushed patch set 26 for main to change 66694 <span data-processor="relativetime" data-value="2026-07-24T14:48:12+00:00" > 07/24/26, 14:48 </span>
-
Gerrit Code Review pushed patch set 27 for main to change 66694 <span data-processor="relativetime" data-value="2026-07-24T14:57:32+00:00" > 07/24/26, 14:57 </span>
-
Gerrit Code Review pushed patch set 28 for main to change 66694 <span data-processor="relativetime" data-value="2026-07-24T15:19:55+00:00" > 07/24/26, 15:19 </span>
-
Gerrit Code Review pushed patch set 1 for 14.3 to change 94935 <span data-processor="relativetime" data-value="2026-07-24T16:22:37+00:00" > 07/24/26, 16:22 </span>
-
Mathias Brodala commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-07-24T16:25:09+00:00" > 07/24/26, 16:25 </span>Applied in changeset commit:21371074dce173660214e969ec3b6672a29fbf4b.
-
Benni Mack changed status
ResolvedClosed <span data-processor="relativetime" data-value="2026-08-11T08:46:35+00:00" > 08/11/26, 08:46 </span> -
Eric Harrer changed Related to #110498 <span data-processor="relativetime" data-value="2026-08-28T16:36:21+00:00" > 08/28/26, 16:36 </span>
-
Nikita Hovratov changed Related to #110025 <span data-processor="relativetime" data-value="2026-09-02T07:48:25+00:00" > 09/02/26, 07:48 </span>
*Backend.php:*
Instead of if ($query->getQuerySettings()->getLanguageOverlayMode() !== ‘hideNonTranslated’) it could also be if (!$query->getQuerySettings()->getLanguageOverlayMode())