Issue Bug Closed

#9000661657: [BUGFIX] Do not fall back to routes on invalid “id” -- missing for typenum and eId

Bostjan Kristl 12/23/19, 09:22 updated 02/19/22, 14:06

Description

In this bug fix 61657: [BUGFIX] Do not fall back to routes on invalid “id”
for fall back is now error page when we use type (typeNum) pages and id as query parameter ! (for eId script i haven’t checked)

————————————————————————————————————————————————————-
*Before fix it was:*


$requestId = (string)($request->getQueryParams()['id'] ?? '');
            if (!empty($requestId) && !empty($page = $this->resolvePageId($requestId))) {

————————————————————————————————————————————————————-
*with buxfix is:*

$requestId = (string)($request->getQueryParams()['id'] ?? '');
            if (!empty($requestId)) {
                $page = $this->resolvePageId($requestId);
                if ($page === null) {
                    return GeneralUtility::makeInstance(ErrorController::class)->pageNotFoundAction(
                        $request,
                        'The requested page does not exist',
                        ['code' => PageAccessFailureReasons::PAGE_NOT_FOUND]
                    );
                }

————————————————————————————————————————————————————-
*BUT is supposed to be:*


$requestId = (string)($request->getQueryParams()['id'] ?? '');

            if (!empty($requestId)) {

                $requestType = (int)($request->getQueryParams()['type'] ?? null);

                if ($requestType !== null && $this->resolvePageId($requestId) === null) {
                    return GeneralUtility::makeInstance(ErrorController::class)->pageNotFoundAction(
                        $request,
                        'The requested page does not exist',
                        ['code' => PageAccessFailureReasons::PAGE_NOT_FOUND]
                    );
                }

Because we need to check if is eID script or type (typeNum) page.

Regards,
Bostjan

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.