#90330Wrong publicUrl for FAL files in non-public storages generated from CLI
Description
In at least TYPO3 9.5.13 fetching the public url of a FAL \TYPO3\CMS\Core\Resource\File located in a non-public storage using $file->getPublicUrl() from the commandline in a Symfony command returns
http:///var/www/example.org/www/typo3/sysext/core/bin/index.php?eID=dumpFile&t=f&f=[fileUid]&token=[token]
Using $file->getPublicUrl(TRUE) returns
../../../../http://var/www/example.org/www/typo3/sysext/core/bin/index.php?eID=dumpFile&t=f&f=[fileUid]&token=[token]
Last changes to that area were done in
https://review.typo3.org/c/Packages/TYPO3.CMS/+/57240/11/typo3/sysext/core/Classes/Resource/ResourceStorage.php#1304
https://review.typo3.org/c/Packages/TYPO3.CMS/+/53140/8/typo3/sysext/core/Classes/Resource/ResourceStorage.php#1297
https://review.typo3.org/c/Packages/TYPO3.CMS/+/53789/5/typo3/sysext/core/Classes/Resource/ResourceStorage.php#1304
This should be a valid URL not mangling local file paths with eID-GET-Parameters.
For TYPO3 9+ it probably should take site configuration in account, otherwise it would even help if at least just the relative path
/index.php?eID=dumpFile&t=f&f=[fileUid]&token=[token]
would be returned
Reviews 1
Related issues 2
History 913
-
Stephan Großberndt commented 02/05/20, 17:13
-
Georg Ringer changed status
NewAccepted 02/06/20, 07:14 -
Stephan Großberndt commented 06/14/23, 15:47
This issue is still present in TYPO3 v12, here
$file->getPublicUrl()and$file->getPublicUrl(TRUE)both returnhttp://bin/index.php?eID=dumpFile&t=f&f=2096&token=bd6e0cc99d3c2a7a6745416bff82d61ce87d44dd
-
Stephan Großberndt changed Related to #100361 09/13/23, 07:47
-
Georg Ringer changed Sprint Focus On Location Sprint 04/16/25, 14:07
-
Gerrit Code Review pushed patch set 1 for main to change 91366 status
AcceptedUnder Review 10/30/25, 13:24 -
Gerrit Code Review pushed patch set 2 for main to change 91366 10/30/25, 13:26
-
Gerrit Code Review pushed patch set 3 for main to change 91366 10/30/25, 15:23
-
Georg Ringer changed Sprint Focus
On Location Sprint08/06/26, 15:48 -
Gerrit Code Review pushed patch set 4 for main to change 91366 09/25/26, 01:31
-
Benni Mack changed Related to #109548 09/25/26, 01:32
-
Benni Mack commented 09/25/26, 01:33
This was fixed with #109548 but we add tests now
-
Anonymous commented and changed status
Under ReviewResolved done0 %100 % 09/25/26, 07:00Applied in changeset commit:ceebf222c966ce8290de1e022b4b9264a2bdc324.
My current workaround:
/** * Cached public URL * * @var string */ private $publicSiteUrl = ''; /** * Cached wrong local path from File::getPublicUrl() * * @var string * @link https://forge.typo3.org/issues/90330 */ private $publicUrlLocalPath = ''; /** * Workaround for "Wrong publicUrl for FAL files in non-public storages generated from CLI" * * @param File $file * @return string * @throws SiteNotFoundException * @link https://forge.typo3.org/issues/90330 */ protected function getPublicUrl(File $file): string { if (empty($this->publicUrlLocalPath)) { $this->publicUrlLocalPath = 'http://' . Environment::getPublicPath() . '/typo3/sysext/core/bin/'; } if (empty($this->publicSiteUrl)) { $siteFinder = GeneralUtility::makeInstance(SiteFinder::class); $this->publicSiteUrl = $siteFinder->getSiteByIdentifier('identifier-of-my-site')->getBase(); } $publicUrl = $file->getPublicUrl(); if (substr($publicUrl, 0, 8) === 'http:///') { $publicUrl = str_replace($this->publicUrlLocalPath, $this->publicSiteUrl, $publicUrl); } return $publicUrl; }