Issue Bug Closed

#91307Image conversion not possible on older systems

Christian Hernmarck 05/05/20, 15:48 updated 08/13/26, 07:48

Description

Because of Feature/Bug #69274 all “gm convert” commands fail because my gm does not know “-auto-orient” and doesn’t do anything (-> no image resize etc is done – neither backend nor frontend).

“-auto-orient” is not present in graphicsmagick delivered with debian wheezy.

/usr/bin/gm convert: Unrecognized operator (-auto-orient).

Since there won’t be many wheezys around I assume I have to patch all sources beginning with v9 – nevertheless I think it’s good to open the ticket so next time a new parameter is used: a version check of gm/im is done before…

My patch look like this:

diff -u -r 9511/typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php typo3_src-9.5.11/typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php
--- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php    2019-10-30 21:46:49.000000000 +0100
+++ typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php    2020-01-23 10:48:32.163352508 +0100
@@ -206,7 +206,8 @@
      *
      * @var string
      */
-    public $scalecmd = '-auto-orient -geometry';
+#    public $scalecmd = '-auto-orient -geometry';
+    public $scalecmd = '-geometry';

     /**
      * Used by v5_blur() to simulate 10 continuous steps of blurring
diff -u -r 9511/typo3/sysext/core/Classes/Utility/CommandUtility.php typo3_src-9.5.11/typo3/sysext/core/Classes/Utility/CommandUtility.php
--- typo3/sysext/core/Classes/Utility/CommandUtility.php        2019-10-30 21:46:49.000000000 +0100
+++ typo3/sysext/core/Classes/Utility/CommandUtility.php        2020-01-23 10:47:23.783107250 +0100
@@ -130,9 +130,9 @@
             }
         }
         // Add -auto-orient on convert so IM/GM respects the image orient
-        if ($parameters && $command === 'convert') {
-            $parameters = '-auto-orient ' . $parameters;
-        }
+#        if ($parameters && $command === 'convert') {
+#            $parameters = '-auto-orient ' . $parameters;
+#        }
         // set interlace parameter for convert command
         if ($command !== 'identify' && $gfxConf['processor_interlace']) {
             $parameters = '-interlace ' . $gfxConf['processor_interlace'] . ' ' . $parameters;

Reviews 1

History 48

  1. Andreas Kienast commented 05/05/20, 15:59

    For the record: LTS of Wheezy ended in May 2018 according to https://www.debian.org/releases/wheezy/.

  2. Christian Eßl commented 05/05/20, 16:33

    And -auto-orient has been supported in graphicsmagick for over 7 years now. So it’s debatable, if there are even still LTS supported OSes out there, that have a graphicsmagick version older than that.

  3. Georg Ringer commented and changed status New Closed 10/20/20, 22:58

    I am closing this issue as this issue won’t be fixed and only occurs with outdated OS

  4. Gerrit Code Review pushed patch set 2 for main to change 91307 status Closed Under Review 10/28/25, 12:00

  5. Gerrit Code Review pushed patch set 3 for main to change 91307 10/29/25, 08:15

  6. Gerrit Code Review pushed patch set 4 for main to change 91307 10/29/25, 09:06

  7. Gerrit Code Review pushed patch set 5 for main to change 91307 10/31/25, 13:28

  8. Georg Ringer commented and changed status Under Review Closed 08/13/26, 07:48

    closing again, has been reopened by gerrit with wrong issue number