Issue Bug Resolved

#91761Links with fragment and without parameters broken

Robert Vock 07/08/20, 10:05 updated 11/10/26, 05:35

Description

When linking from a page with parameters to the same page without parameters but with a fragment, the link only contains the fragment. This means the browser does not follow the link, but stays on the same page.

This is a regression introduced with #89068

The problem is, that the check for queryParameters does not check if the current page has parameters:
PageLinkBuilder.php#L399

This breaks the “Return to login form” in felogin on the “Forgot password” page, if the following config is used:

plugin.tx_felogin_pi1.linkConfig.section.field = uid

The Back Link on the Forgot-Password Page will not lead back to the login form, because the tx_felogin_pi1[forgot]=1 parameter is still present in the url.

Current workaround is:

plugin.tx_felogin_pi1.linkConfig.forceAbsoluteUrl = 1

Reviews 3

History 620

  1. Robert Vock changed Related to #89068 07/08/20, 10:05

  2. Alexander Opitz commented 10/06/20, 10:28

    Also working with RouteEnhancers got problematic.

    We have
    employees as page which shows content of listAction
    employees/detail which is same page but inside the detailAction

    On the employees page is a content element with a rte field which contains following link t3://page?uid=17#231 which leads to the output List so the user never comes back from RouteEnhancers subpath.

  3. Oliver Hader changed Sprint Focus On Location Sprint 11/03/22, 14:06

  4. Gerrit Code Review pushed patch set 1 for main to change 76794 status New Under Review 11/23/22, 17:28

  5. Gerrit Code Review pushed patch set 2 for main to change 76794 11/23/22, 22:02

  6. Gerrit Code Review pushed patch set 3 for main to change 76794 12/20/22, 22:05

  7. Gerrit Code Review pushed patch set 4 for main to change 76794 12/21/22, 10:12

  8. Gerrit Code Review pushed patch set 5 for main to change 76794 12/21/22, 16:28

  9. Gerrit Code Review pushed patch set 6 for main to change 76794 12/22/22, 20:54

  10. Gerrit Code Review pushed patch set 7 for main to change 76794 12/22/22, 23:30

  11. Gerrit Code Review pushed patch set 8 for main to change 76794 01/10/23, 10:09

  12. Gerrit Code Review pushed patch set 9 for main to change 76794 05/03/23, 09:28

  13. Gerrit Code Review pushed patch set 10 for main to change 76794 05/03/23, 11:53

  14. Benni Mack changed status Under Review Accepted 07/05/23, 14:03

  15. Benni Mack changed Sprint Focus On Location Sprint 08/02/23, 13:05

  16. Gerrit Code Review pushed patch set 1 for main to change 97059 status Accepted Under Review 10/23/26, 08:55

  17. Gerrit Code Review pushed patch set 2 for main to change 97059 10/23/26, 12:18

  18. Gerrit Code Review pushed patch set 1 for 14.3 to change 97480 11/09/26, 21:47

  19. Gerrit Code Review pushed patch set 2 for 14.3 to change 97480 11/09/26, 22:08

  20. Benni Mack commented and changed status Under Review Resolved done 0 % 100 % 11/10/26, 05:35

    Applied in changeset commit:71f15d1f6fd752d68b6bcc6e97e3e63f540aeba0.