Issue Task Closed

#91910Add working default icon for Backend Layout Builder Page TS

Nikita Hovratov 07/31/20, 12:46 updated 07/09/24, 12:00

Description

When creating a new backend layout record it is possible to show the equivalent page ts config.
This shows something like this:

mod.web_layout.BackendLayouts {
  exampleKey {
    title = Example
--> icon = EXT:example_extension/Resources/Public/Images/BackendLayouts/default.gif
    config {
      backend_layout {
        colCount = 1
        rowCount = 1
        rows {
          1 {
            columns {
              1 {
                name = 0x0
                colPos = 1
              }
            }
          }
        }
      }
    }
  }
}

People might forget changing the icon. Add a working icon example to mitigate any errors resulting from that.

Reviews 2

History 812

  1. Nikita Hovratov changed description 07/31/20, 12:48

  2. Georg Ringer commented and changed status New Needs Feedback 08/03/20, 08:03

    Thanks for creating the issue. I am wondering: What is the benefit having the path to a working default icon? Important is to have the configuration which works and which can be used modfied later on.

  3. Nikita Hovratov commented 08/03/20, 10:44

    Georg Ringer wrote:
    > Thanks for creating the issue. I am wondering: What is the benefit having the path to a working default icon? Important is to have the configuration which works and which can be used modfied later on.

    Hi Georg, i agree with you. In my case the issue was people copying the configuration and forget to change the icon later on. This led to an error with the mask extension because of the missing icon. So the benefit would be to prevent such cases with either adding a working default icon or completely comment out the icon property.

  4. Benni Mack commented 10/27/21, 13:05

    Hey Nikita,

    sure, but did they copy it from the official docs or from somewhere in their other project?

  5. Nikita Hovratov commented 10/27/21, 13:21

  6. Gerrit Code Review pushed patch set 1 for main to change 84529 status Needs Feedback Under Review 06/08/24, 08:02

  7. Gerrit Code Review pushed patch set 2 for main to change 84529 06/08/24, 17:11

  8. Gerrit Code Review pushed patch set 1 for 12.4 to change 84752 06/18/24, 06:55

  9. Georg Ringer commented and changed status Under Review Resolved done 0 % 100 % 06/18/24, 06:55

    Applied in changeset commit:103288b971ce6fe27a270e88bab4c31557b1d0b5.

  10. Gerrit Code Review pushed patch set 2 for 12.4 to change 84752 status Resolved Under Review 06/18/24, 07:02

  11. Georg Ringer commented and changed status Under Review Resolved 06/18/24, 07:15

    Applied in changeset commit:14242366ae6509435fcab79adce28929f0e7b24c.

  12. Benni Mack changed status Resolved Closed 07/09/24, 12:00