Issue Bug Closed

#93466createVersionNumberedFilename doesn't support absolute paths

Jonas Renggli 02/08/21, 14:46 updated 02/03/23, 16:15

Description

Just discovered that files in TYPO3 Backend are lacking cache busting, e.g.

https://example.com/typo3/sysext/backend/Resources/Public/Css/backend.css

This used to work in TYPO3 8

https://example.com/typo3/sysext/backend/Resources/Public/Css/backend.css?1599168500

As far as I see, the root cause is `getRegisteredStylesheetFolders()` returning absolute file names, but `createVersionNumberedFilename` expects relative file names and therefore ignores the file completely.

public/typo3/sysext/backend/Classes/Template/ModuleTemplate.php::getRegisteredStylesheetFolders()

    /**
     * Returns an array of all stylesheet directories registered via $TBE_STYLES['skins']
     */
    protected function getRegisteredStylesheetFolders(): array
    {
        $stylesheetDirectories = [];
        foreach ($GLOBALS['TBE_STYLES']['skins'] ?? [] as $skin) {
            foreach ($skin['stylesheetDirectories'] ?? [] as $stylesheetDir) {
                $directory = GeneralUtility::getFileAbsFileName($stylesheetDir);
                if (!empty($directory)) {
                    $stylesheetDirectories[] = $directory;
                }
            }
        }
        return $stylesheetDirectories;
    }

public/typo3/sysext/core/Classes/Utility/GeneralUtility.php::createVersionNumberedFilename()

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.