#93729Wrong check for undefined in DateTimePicker
Description
64 if (element.dataset.datepickerInitialized !== 'undefined') {
65 return;
66 }
Should be typeof check
Reviews 1
History 45
-
Gerrit Code Review pushed patch set 1 for master to change 68374 status
NewUnder Review 03/13/21, 15:40 -
Tymoteusz Motylewski commented 03/13/21, 19:12
-
Nikita Hovratov commented 03/13/21, 19:17
Tymoteusz Motylewski wrote in #note-2:
> any hints how to reproduce it? CR seems easy, but would like to give “verified” vote too.I found this by upgrading my extension to v11. I don’t know if you can find an error in TYPO3 itself.
But this is definetely wrong if you compare this with version 10.4, where the typeof check was still present:const $dateTimeFields = $(selector || this.fieldSelector).filter((index: number, element: HTMLElement): boolean => { return typeof $(element).data('DateTimePicker') === 'undefined'; }); -
Nikita Hovratov commented and changed status
Under ReviewResolved done0 %100 % 03/14/21, 18:20Applied in changeset commit:29d689cb41a31a01f5e7f1a30ef85c7ec42f2174.
-
Benni Mack changed status
ResolvedClosed 05/07/21, 19:37
any hints how to reproduce it? CR seems easy, but would like to give “verified” vote too.