#93823ResourceFactory::retrieveFileOrFolderObject() wrongly returns Folder instead of File object
Description
In some situations, ResourceFactory::retrieveFileOrFolderObject($input) wrongly returns a Folder object instead of a File object.
This occured in a composer based installation when $input is anything outside public web path like “var/www/html/var/transient/youtube_1e65d7002154f3586b97bd19d2787829.jpg” (a preview image created by TYPO3\CMS\Core\Resource\OnlineMedia\Helpers\YouTubeHelper).
The wrong check seems to happen in line 485…
$input = PathUtility::getCanonicalPath(ltrim($input, '/'));
if (@is_file(Environment::getPublicPath() . '/' . $input)) {
// only the local file
return $this->getFileObjectFromCombinedIdentifier($input);
}
// only the local path
return $this->getFolderObjectFromCombinedIdentifier($input);
It should be easy to reproduce:
- Upload any youtube or vimeo video from backend
- Assign it to any record or model
- In FLUID, let it be rendered using “<f:image>“ (when using “image” tag instead of “media” viewhelper, this automatically creates the thumbnail)</f:image>
This crashes the frontend!
I don’t know if this bug is part of ResourceFactory::retrieveFileOrFolderObject() rather than YouTubeHelper::getPreviewImage() (which might create the thumbnail on the wrong location.
Independent from this being related to the “online media stuff”, anyway the “retrieveFileOrFolderObject()” must not return a folder object in this case (perhaps better just “false” or throw an exception when neither file nor folder?).
Reviews 2
Related issues 1
History 1320
-
Jan Kornblum changed description 03/26/21, 23:08
-
Jan Kornblum changed description 03/26/21, 23:09
-
Jan Kornblum changed description 03/29/21, 10:39
-
Jan Kornblum changed description 03/29/21, 10:41
-
Jan Kornblum changed description 03/29/21, 10:44
-
Jan Kornblum changed description 03/30/21, 08:30
-
Jan Kornblum changed description 03/31/21, 11:01
-
Jan Kornblum changed description 04/06/21, 14:30
-
Jan Kornblum changed description 04/06/21, 14:31
-
Jan Kornblum changed Related to #93860 04/06/21, 15:40
-
Gerrit Code Review pushed patch set 1 for main to change 89115 status
NewUnder Review 04/15/25, 12:01 -
Gerrit Code Review pushed patch set 2 for main to change 89115 04/15/25, 12:25
-
Gerrit Code Review pushed patch set 3 for main to change 89115 04/16/25, 06:52
-
Gerrit Code Review pushed patch set 1 for 13.4 to change 89134 04/16/25, 09:08
-
Gerrit Code Review pushed patch set 2 for 13.4 to change 89134 04/16/25, 09:08
-
Benni Mack commented and changed status
Under ReviewResolved done0 %100 % 04/16/25, 09:10 -
Gerrit Code Review pushed patch set 3 for 13.4 to change 89134 status
ResolvedUnder Review 04/16/25, 09:12 -
Gerrit Code Review pushed patch set 4 for 13.4 to change 89134 04/16/25, 09:16
-
Benni Mack commented and changed status
Under ReviewResolved 04/16/25, 09:30Applied in changeset commit:edcad5183537cc56cb26ee8a9cb445a3e18805f2.
-
Benni Mack changed status
ResolvedClosed 12/02/25, 14:33
Applied in changeset commit:1c092692abd778810be17ccf5af0000b5eb4baa0.