#95840TcaPreparation::prepareQuotingOfTableNamesAndColumnNames() skips types columnsOverrides
Description
\TYPO3\CMS\Core\Preparations\TcaPreparation::prepareQuotingOfTableNamesAndColumnNames() is buggy:
The method only traverses 'columns' of each table, to quote identifiers marked like {#identifier} in TCA SQL parts.
However, such TCA SQL parts – like foreign_table_where – might also occur in overridden columns of specified types, like: $GLOBALS['TCA'][<table>]['types'][<type>]['columnsOverrides'][<column>]['config'].
Therefore, to fix this bug, all types must be traversed as well, and identifiers quoted.
Otherwise, identifiers marked like {#identifier} in TCA SQL parts of columnsOverrides sections are not quoted, resulting in SQL syntax errors.
At least TYPO3 10, 11 and the development branch are affected. (https://github.com/TYPO3/typo3/blob/master/typo3/sysext/core/Classes/Preparations/TcaPreparation.php#L189)
Reviews 0
No change resolves or names this issue in its commit message, and no comment links one.
History 2
-
Benni Mack commented 07/03/23, 12:34
-
Benni Mack commented and changed status
NewClosed 10/15/26, 18:57Closing this now as it does not happen in v12+ anymore.
Side-note: Only happens in v11, not in v12 anymore.