Issue Bug Closed

#96399Invalid string cast of idn_to_ascii()

Andreas Kienast 12/20/21, 14:26 updated 10/04/22, 14:14

Description

GeneralUtility::isValidUrl() makes use of idn_to_ascii, whose result is cast to string. Afterward, the result is checked for being false, which does not make sense in this context, as this will never be false.

Reviews 2

History 25

  1. Gerrit Code Review pushed patch set 1 for main to change 72740 status New Under Review 12/20/21, 14:29

  2. Gerrit Code Review pushed patch set 2 for main to change 72740 12/20/21, 14:30

  3. Gerrit Code Review pushed patch set 1 for 11.5 to change 72720 12/20/21, 22:05

  4. Andreas Fernandez commented and changed status Under Review Resolved done 0 % 100 % 12/20/21, 22:10

    Applied in changeset commit:aece622c98db69b26486a4b921c9198d7de2bbbb.

  5. Benni Mack changed status Resolved Closed 10/04/22, 14:14