#96399Invalid string cast of idn_to_ascii()
Description
GeneralUtility::isValidUrl() makes use of idn_to_ascii, whose result is cast to string. Afterward, the result is checked for being false, which does not make sense in this context, as this will never be false.
Reviews 2
History 25
-
Gerrit Code Review pushed patch set 1 for main to change 72740 status
NewUnder Review 12/20/21, 14:29 -
Gerrit Code Review pushed patch set 2 for main to change 72740 12/20/21, 14:30
-
Gerrit Code Review pushed patch set 1 for 11.5 to change 72720 12/20/21, 22:05
-
Andreas Fernandez commented and changed status
Under ReviewResolved done0 %100 % 12/20/21, 22:10 -
Benni Mack changed status
ResolvedClosed 10/04/22, 14:14
Applied in changeset commit:aece622c98db69b26486a4b921c9198d7de2bbbb.