Issue Bug Closed

#96509Vimeo Online Media helper fetches incorrect media ID from embed snippet

Jigal van Hemert 01/11/22, 13:13 updated 10/04/22, 14:17

Description

The Vimeo Online Media Helper tries to extract the media ID from various types of vimeo URLs. The regular expression was modified to support event type URLs and at that moment a bug was introduced that included the leading slash in the media ID.

Reviews 4

History 69

  1. Oliver Hader commented 01/11/22, 14:43

    Do you have an issue number which introduced that regular expression you mentioned?
    Can you please post the Vimeo ID or URL you have been using (just to see the format/structure)?

  2. Oliver Hader commented 01/11/22, 14:45

    Are you referring to this change?
    https://review.typo3.org/c/Packages/TYPO3.CMS/+/69953/2/typo3/sysext/core/Classes/Resource/OnlineMedia/Helpers/VimeoHelper.php

    Currently

    ...(?:video|event\/)...

    Should have been (allowing either video/ or event/)

    ...(?:video\/|event\/)...
  3. Oliver Hader commented and changed status New Accepted start date 01/11/22, 14:52

    https://regex101.com/r/uLXbGA/1 shows the problem – and that the ID 7215347324/hasf8a65sdsa7d now has that leading slash /7215347324/hasf8a65sdsa7d

    Introduced for v11.4.0 and v10.4.20
    → https://review.typo3.org/q/I8c074372c3c42b8c5a74afff7b9fb386c2f136a2

  4. Gerrit Code Review pushed patch set 1 for main to change 72967 status Accepted Under Review 01/11/22, 14:57

  5. Jigal van Hemert commented 01/11/22, 15:07

    Oliver Hader wrote in #note-3:
    > https://regex101.com/r/uLXbGA/1 shows the problem – and that the ID 7215347324/hasf8a65sdsa7d now has that leading slash /7215347324/hasf8a65sdsa7d
    >
    > Introduced for v11.4.0 and v10.4.20
    > → https://review.typo3.org/q/I8c074372c3c42b8c5a74afff7b9fb386c2f136a2

    Yes, the ‘\/’ was missing after the “video” part.

  6. Gerrit Code Review pushed patch set 1 for 11.5 to change 72968 01/11/22, 16:33

  7. Gerrit Code Review pushed patch set 1 for 10.4 to change 72969 01/11/22, 16:37

  8. Oliver Hader commented and changed status Under Review Resolved done 0 % 100 % 01/11/22, 16:40

    Applied in changeset commit:0e0524b5a9557b925b988f522579042251e146d6.

  9. Benni Mack changed status Resolved Closed 10/04/22, 14:17