Issue Bug Closed

#96890Wrong processing and display of native datetime(dbType) fields due to server timezone

Imko Schumacher 02/14/22, 20:01 updated 12/02/25, 14:33

Description

Wrong processing and display of native datetime(dbType) fields due to server timezone

Inside DatabaseRowDateTimeFields class native datetime (dbType) values are treated as UTC values, whereas the rest uses the local timezone (e.g. BackendUtility::datetime).
This causes the TCA title (bug 1) and readOnly fields (bug 2) to be formatted wrong (with an time offset).
The conversion also breaks the title for time fields (bug 3) completely.

Prerequisite

  • Timezone != ‘UTC’, e.g. timezone: America/New_York (.ddev/config.yaml)
  • Specified configuration (see below)

Steps to reproduce

Bug 1

  1. Create a new DateTime title error record and set mydatetime to 12:00 20-02-2022
  2. Save record
  3. Look at the record title
    • Actual value (wrong time): Edit DateTime title error "20-02-22 07:00" on page "recordStorage"
    • Expected value: Edit DateTime title error "20-02-22 12:00" on page "recordStorage"
      dateTimeTitle-saved.png

Bug 2

  1. Uncomment readOnly in TCA and clear cache/reload
  2. Open record from bug 1
  3. Look at the disable field (mydatetime)

Bug 3

  1. Change TCA config for bug 3 and clear cache/reload
  2. Create a new DateTime title error record and set mytime to 12:00
  3. Save record

Configuration

TCA:

return [
    'ctrl' => [
        'title' => 'DateTime title error',
        'label' => 'mydatetime', // Bug 1 and 2
        // 'label' => 'time', // Bug 3
    ],
    'columns' => [
        // Bug 1 and 2
        'mydatetime' => [
            'label' => 'mydatetime',
            'config' => [
                'type' => 'input',
                'renderType' => 'inputDateTime',
                'dbType' => 'datetime',
                'eval' => 'datetime,null',
                // 'readOnly' => true, // Bug 2
            ],
        ],
        // Bug 3
        'mytime' => [
            'label' => 'mytime',
            'config' => [
                'type' => 'input',
                'renderType' => 'inputDateTime',
                'dbType' => 'time',
                'eval' => 'time,null',
            ],
        ],
    ],
    'types' => [
        '0' => ['showitem' => 'mydatetime,mytime'],
    ],
];

SQL:

mydatetime datetime default NULL,
mytime time default NULL,

Source of the problem

Classes using this value (as far as I know)

  • Bug 1: TcaRecordTitle:320,360
    • Example dataflow
      • Database: 2022-02-22 12:00
      • DatabaseRowDateTimeFields: generates a string like 2022-02-22T07:00:00-05:00 (UTC)
      • TcaRecordTitle: converted to a timestamp by strtotime to 1645531200
      • TcaRecordTitle: converted by BackendUtility::datetime (with date function, formats in server timezone) to 2022-02-22 07:00
  • Bug 2: InputDateTimeElement:114
  • Bug 3: TcaRecordTitle???
  • Custom functions using formattedLabel_userFunc

Reviews 3

Files 3

History 1032

Show 67 earlier messages
  1. Imko Schumacher commented <span data-processor="relativetime" data-value="2022-02-15T17:55:32+00:00" > 02/15/22, 17:55 </span>

    Some hints for possible solutions:

    Option A

    Remove the first part of the if clause or even the whole file (DatabaseRowDateTimeFields):
    • Needs adjustments inside InputDateTimeElement
    • Matches “assumptions” inside TcaRecordTitleTest (2014-12-31 23:59:59) better
    • check other places
    • …

    Option B (simple, but not lasting)

    Remove the @ . ‘ UTC’@ in DatabaseRowDateTimeFields:47

                        $result['databaseRow'][$column] = date('c', (int)strtotime($result['databaseRow'][$column]));
    Problems:
    • Does not fix bug 3
    • This and the current solution does not match expectations in the core
  2. Imko Schumacher commented and changed TYPO3 Version 11 13 <span data-processor="relativetime" data-value="2023-12-04T17:32:11+00:00" > 12/04/23, 17:32 </span>

    Bugs are still present in TYPO3 v13 (tested with 9e1e9493ff5e0b615e4921b2612226c684759d3f).

    Updated TCA;

    return [
        'ctrl' => [
            'title' => 'DateTime title error',
            'label' => 'mydatetime', // Bug 1 and 2
            // 'label' => 'mytime', // Bug 3
        ],
        'columns' => [
            // Bug 1 and 2
            'mydatetime' => [
                'label' => 'mydatetime',
                'config' => [
                    'type' => 'datetime',
                    'format' => 'datetime',
                    'dbType' => 'datetime',
                    'nullable' => true,
                    // 'readOnly' => true, // Bug 2
                ],
            ],
            // Bug 3
            'mytime' => [
                'label' => 'mytime',
                'config' => [
                    'type' => 'datetime',
                    'format' => 'time',
                    'dbType' => 'time',
                    'nullable' => true,
                ],
            ],
        ],
        'types' => [
            '0' => ['showitem' => 'mydatetime,mytime'],
        ],
    ];
  1. Benjamin Franzke commented and changed status Under Review Resolved done 0 % 100 % <span data-processor="relativetime" data-value="2025-04-04T07:30:09+00:00" > 04/04/25, 07:30 </span>

    Applied in changeset commit:da29fc6fe375cc03ea870f79697e7a7458de2402.

  2. Gerrit Code Review pushed patch set 1 for 13.4 to change 88944 status Resolved Under Review <span data-processor="relativetime" data-value="2025-04-04T08:17:02+00:00" > 04/04/25, 08:17 </span>

  3. Benjamin Franzke commented and changed status Under Review Resolved <span data-processor="relativetime" data-value="2025-04-04T09:50:08+00:00" > 04/04/25, 09:50 </span>

    Applied in changeset commit:35164c8c9a93d379fbd065bb5fb77340cb150951.