#96929TCA / TCA overrides with variable leaks
Description
All TCA and TCA overrides files are included without any scoping. This means that variables defined in these files can leak into the following files.
Also all variables defined in ExtensionManagementUtility::buildBaseTcaFromSingleFiles() exist in TCA and TCA override files and could even be manipulated.
Possible solution: wrap the require calls for TCA / TCA override files with a closure.
Reviews 1
History 313
-
Christian Kuhn commented 02/16/22, 15:39
-
Gerrit Code Review pushed patch set 1 for main to change 73731 status
NewUnder Review 02/26/22, 22:50 -
Gerrit Code Review pushed patch set 2 for main to change 73731 02/26/22, 22:53
-
Gerrit Code Review pushed patch set 3 for main to change 73731 02/26/22, 23:06
-
Gerrit Code Review pushed patch set 4 for main to change 73731 02/26/22, 23:11
-
Gerrit Code Review pushed patch set 5 for main to change 73731 02/26/22, 23:35
-
Gerrit Code Review pushed patch set 6 for main to change 73731 02/27/22, 15:07
-
Gerrit Code Review pushed patch set 7 for main to change 73731 02/28/22, 20:20
-
Gerrit Code Review pushed patch set 8 for main to change 73731 03/01/22, 19:28
-
Gerrit Code Review pushed patch set 9 for main to change 73731 03/05/22, 11:47
-
Gerrit Code Review pushed patch set 10 for main to change 73731 03/05/22, 12:03
-
Stefan Bürk commented and changed status
Under ReviewResolved done0 %100 % 03/05/22, 23:15Applied in changeset commit:a58a7c7494357eda116ae30bdd4213c7e7d913a4.
-
Benni Mack changed status
ResolvedClosed 10/04/22, 08:38
good idea.