#97559Attributes: Use constructor parameter per property instead of an array
Description
I saw that with v12 attribute support.
Unfortunately, i find it counterproductive that arrays are used for the parameters here. This breaks type safety, breaks code completion, and can easily lead to overlooked typos.
constructor parameters for each parameter would also make it easier to show the programmers which parameters are required.
PHP 8 offers named parameters, so the argument that you don’t have to fill in all parameters with the array, wouldn’t count.
Reviews 2
Related issues 1
Files 1
History 920
-
Markus Pircher commented and changed attached Bildschirmfoto 2022-05-06 um 08.36.20.png <span data-processor="relativetime" data-value="2022-05-06T06:38:14+00:00" > 05/06/22, 06:38 </span>
-
Benni Mack changed target version <span data-processor="relativetime" data-value="2022-10-04T19:42:08+00:00" > 10/04/22, 19:42 </span>
-
Benni Mack changed target version <span data-processor="relativetime" data-value="2023-01-24T21:29:50+00:00" > 01/24/23, 21:29 </span>
-
Benni Mack changed target version <span data-processor="relativetime" data-value="2023-02-08T16:02:56+00:00" > 02/08/23, 16:02 </span>
-
Benni Mack changed target version <span data-processor="relativetime" data-value="2023-04-05T09:52:56+00:00" > 04/05/23, 09:52 </span>
-
Benni Mack changed target version <span data-processor="relativetime" data-value="2023-06-05T09:23:02+00:00" > 06/05/23, 09:23 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 90296 status
NewUnder Review <span data-processor="relativetime" data-value="2025-10-10T08:19:01+00:00" > 10/10/25, 08:19 </span> -
Gerrit Code Review pushed patch set 4 for main to change 90296 <span data-processor="relativetime" data-value="2025-10-13T14:25:08+00:00" > 10/13/25, 14:25 </span>
-
Gerrit Code Review pushed patch set 5 for main to change 90296 <span data-processor="relativetime" data-value="2025-10-14T12:56:31+00:00" > 10/14/25, 12:56 </span>
-
Gerrit Code Review pushed patch set 6 for main to change 90296 <span data-processor="relativetime" data-value="2025-10-14T14:01:05+00:00" > 10/14/25, 14:01 </span>
-
Gerrit Code Review pushed patch set 7 for main to change 90296 <span data-processor="relativetime" data-value="2025-10-14T15:06:53+00:00" > 10/14/25, 15:06 </span>
-
Gerrit Code Review pushed patch set 8 for main to change 90296 <span data-processor="relativetime" data-value="2025-10-14T15:13:00+00:00" > 10/14/25, 15:13 </span>
-
Gerrit Code Review pushed patch set 9 for main to change 90296 <span data-processor="relativetime" data-value="2025-10-14T15:24:20+00:00" > 10/14/25, 15:24 </span>
-
Gerrit Code Review pushed patch set 10 for main to change 90296 <span data-processor="relativetime" data-value="2025-10-14T19:53:35+00:00" > 10/14/25, 19:53 </span>
-
Gerrit Code Review pushed patch set 11 for main to change 90296 <span data-processor="relativetime" data-value="2025-11-14T07:31:00+00:00" > 11/14/25, 07:31 </span>
-
Gerrit Code Review pushed patch set 12 for main to change 90296 <span data-processor="relativetime" data-value="2025-11-14T07:58:26+00:00" > 11/14/25, 07:58 </span>
-
Christian Kuhn changed Related to #107229 <span data-processor="relativetime" data-value="2025-11-20T12:01:42+00:00" > 11/20/25, 12:01 </span>
-
Gerrit Code Review pushed patch set 13 for main to change 90296 <span data-processor="relativetime" data-value="2025-11-20T12:06:16+00:00" > 11/20/25, 12:06 </span>
-
Anonymous commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2025-11-20T13:15:09+00:00" > 11/20/25, 13:15 </span>Applied in changeset commit:d06cc54897151923107b6dbd35fc1506d1225450.
-
Benni Mack changed status
ResolvedClosed <span data-processor="relativetime" data-value="2025-12-02T14:33:55+00:00" > 12/02/25, 14:33 </span>
doctrine/annotation has named nonstructor option, so the backward compatibility would be given, and the syntax for both annotation and attribute would be almost identical
https://www.doctrine-project.org/projects/doctrine-annotations/en/1.13/custom.html#optional-constructors-with-named-parameters
Both Neos Flow and doctrine ORM use that.