Issue Task Closed

#97602Always call GU::trimExplode with a string parameter

Oliver Klee 05/10/22, 15:14 updated 03/18/25, 10:29

Description

This avoids type errors when GeneralUtility is switched to strict mode.

Reviews 1

History 1214

  1. Oliver Klee changed Blocks #97578 05/10/22, 15:15

  2. Georg Ringer changed status New Accepted 05/10/22, 15:43

  3. Georg Ringer changed subject Always call GU::trimeExplode with a string parameter Always call GU::trimExplode with a string parameter 05/10/22, 15:43

  4. Oliver Klee changed Blocks #97578 07/09/22, 10:47

  5. Oliver Klee commented 07/09/22, 10:48

    This is not necessary (at least not for marking GU as strict): GU::trimExplode already casts the parameter to string. So this ticket can be closed.

  6. Oliver Klee commented 07/09/22, 10:50

    Ah, let’s keep this open as this will become necessary once GU::trimExplode has native type declarations (and GU is marked as strict).

  7. Oliver Klee commented 07/09/22, 12:41

    There are really a lot a places to change. We should split this up:

    - backend
    - core
    - extbase & fluid
    - felogin
    - frontend
    - install
    - recordlist
    - workspaces
    - everything else

  8. Oliver Klee changed tracker Bug Epic TYPO3 Version 12 07/16/22, 17:05

  9. Oliver Klee changed Blocked by #97960 07/16/22, 17:10

  10. Benni Mack changed target version 06/05/23, 09:21

  11. Gerrit Code Review pushed patch set 1 for main to change 81964 status Accepted Under Review 11/26/23, 08:46

  12. Gerrit Code Review pushed patch set 2 for main to change 81964 11/26/23, 08:54

  13. Georg Ringer commented 03/18/25, 10:26

    request to close issue from author as he currently doesn’t plan to work on those issues.

    If you find the issue valid and want to work on that, feel free to comment or contact me on slack

  14. Georg Ringer changed tracker Epic Task status Under Review Closed TYPO3 Version 12 03/18/25, 10:29