#97662When removing translated page from the recycler, deletion goes too far and hard delete content elements related to the default language page
Description
As said in the title, one of our client filled a bug report claiming some content elements were lost while deleting records using the Recycler. We checked the code and found out a way to reproduce this bug with v10.4.27 and v11.5.10.
Here is how to reproduce:
- Using a site with multiple languages configured
- Default: English
- Secondary: French
- Create a new page using the default language (ie: English)
- Create a text content element in it (or any type of content element)
- Create a new translation to this page —> French
- Create a new text element for the translation
- Test that both languages works fine
- Delete the translation, not the content element, to return with only the default language (deleting the french version)
- At this point, using the Recycle module, we can see the deleted french translation page
- Going back in the Page module, create a new translation of that same page in French again
- Add content elements to this new French translation
- Using the Recycler module, permanently delete the first (deleted) translation page
- When going back to the page module, on the original page, we can witness the latest french content elements are deleted permanently
By tracking every steps of the Recycler, from the delete button to the function TYPO3\CMS\Core\DataHandling\DataHandler\deleteSpecificPage() it became obvious that, when the page deletion occures, the function getDefaultLanguagePageId() will return the value of l10n_parent field and will directly link any tt_content using the uid of the default language page.
Reviews 2
Related issues 1
History 1218
-
Andreas Kießling commented <span data-processor="relativetime" data-value="2022-06-21T16:13:29+00:00" > 06/21/22, 16:13 </span>
-
Kai Sulkowski commented and changed TYPO3 Version
1011 PHP Version7.45.3 <span data-processor="relativetime" data-value="2024-02-05T14:06:08+00:00" > 02/05/24, 14:06 </span>This bug is really devastating. We emptied our recyclers and a lot of content was irretrievably lost!
-
Riccardo De Contardi commented <span data-processor="relativetime" data-value="2024-04-13T22:20:07+00:00" > 04/13/24, 22:20 </span>
Still reproducible on 13.1.0-dev
-
Riccardo De Contardi changed Sprint Focus On Location Sprint <span data-processor="relativetime" data-value="2024-06-29T19:38:51+00:00" > 06/29/24, 19:38 </span>
-
Tim Lochmüller commented and changed TYPO3 Version
1112 PHP Version5.38.2 <span data-processor="relativetime" data-value="2025-01-31T22:00:15+00:00" > 01/31/25, 22:00 </span>Run into the same problem today and have to restore many CEs from a DB backup. Very annoying this bug and I think, currently the best solution is either remove recycler extension from the instance or remove pages manually via DB (without the data handler magic).
-
Andreas Kießling commented <span data-processor="relativetime" data-value="2025-02-05T11:24:57+00:00" > 02/05/25, 11:24 </span>
Having the recycler installed by default for v13 makes it even worse…
-
Matthias Kappenberg commented <span data-processor="relativetime" data-value="2025-05-14T06:00:08+00:00" > 05/14/25, 06:00 </span>
Can this ticket be given high priority please.
I can reproduce it the current 13.4.10, too. -
Garvin Hicking commented <span data-processor="relativetime" data-value="2025-05-14T15:16:48+00:00" > 05/14/25, 15:16 </span>
Is this the same issue as https://forge.typo3.org/issues/106658 , which has been fixed?
-
Andreas Wolf commented and changed status
NewAccepted TYPO3 Version1214 <span data-processor="relativetime" data-value="2025-05-16T08:11:04+00:00" > 05/16/25, 08:11 </span>Unfortunately not, I just tried it on latest master including Lollis recent change, and the behaviour is still the same, i.e. the bug is still present.
The important thing here is that there must be a deleted translation of the page and an active one. The deleted translation of the page is removed together with all (!) content for that translation, also content that is still active and coupled to the active translation of the page. This active translation of the page is also left untouched.
-
Gerrit Code Review pushed patch set 1 for main to change 89471 status
AcceptedUnder Review <span data-processor="relativetime" data-value="2025-05-20T09:14:19+00:00" > 05/20/25, 09:14 </span> -
Gerrit Code Review pushed patch set 2 for main to change 89471 <span data-processor="relativetime" data-value="2025-05-20T10:19:37+00:00" > 05/20/25, 10:19 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 89471 <span data-processor="relativetime" data-value="2025-05-20T11:03:04+00:00" > 05/20/25, 11:03 </span>
-
Gerrit Code Review pushed patch set 4 for main to change 89471 <span data-processor="relativetime" data-value="2025-05-20T11:45:05+00:00" > 05/20/25, 11:45 </span>
-
Gerrit Code Review pushed patch set 5 for main to change 89471 <span data-processor="relativetime" data-value="2025-05-20T13:14:15+00:00" > 05/20/25, 13:14 </span>
-
Gerrit Code Review pushed patch set 1 for 13.4 to change 89489 <span data-processor="relativetime" data-value="2025-05-20T15:26:21+00:00" > 05/20/25, 15:26 </span>
-
Christian Kuhn commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2025-05-20T15:40:07+00:00" > 05/20/25, 15:40 </span>Applied in changeset commit:84bffd04033570c0fdeec008a947573db4ed0263.
-
Steffen Mächtel changed Related to #107408 <span data-processor="relativetime" data-value="2025-09-24T14:59:56+00:00" > 09/24/25, 14:59 </span>
-
Benni Mack changed status
ResolvedClosed <span data-processor="relativetime" data-value="2025-12-02T14:33:55+00:00" > 12/02/25, 14:33 </span>
This bug is massive! We also suffered data loss due to this faulty behavior which tracks back to https://github.com/TYPO3/typo3/commit/4f4b1710458437830a4c82c59d641702dd9bc817 which was apparently merged to 9.5 already