Issue Feature Closed

#97754Refactoring: Add repository and data mapper for WorkspaceRecord/AbstractRecord

Oliver Klee 06/09/22, 11:31 updated 11/22/24, 16:28

Description

In \TYPO3\CMS\Workspaces\Domain\Record\WorkspaceRecord::get(), there are two patterns hidden that want to be emerge:

public static function get($uid, array $record = null)
{
if (empty($uid)) {
$record = [];
} elseif (empty($record)) {
$record = static::fetch(‘sys_workspace’, $uid);
}
return new self($record);
}

We should refactor this to the following structures:

- (Abstract)DataMapper: has a method to convert an array (which can also be empty) of data to an AbstractRecord instance
- WorkpaceRecordMapper: extends DataMapper
- AbstractRecordRepository::getByUid: retrieves a record from the DB an creates a record model instance; uses the data mapper
- WorkspaceRecordRepository extends AbstractRecordRepository

We also should deprecate WorkspaceRecord::get() and adapt all callers to use the repository or data mapper.

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.

History 3

  1. Oliver Bartsch commented and changed status New Closed <span data-processor="relativetime" data-value="2024-11-22T16:28:30+00:00" > 11/22/24, 16:28 </span>

    Hi Oliver,

    I think we should not implement such solution, since it is targeting workspaces only. We’ve worked in this area recently by implementing the RecordInterface with the RawRecord and Record DTOs – together with corresponding RecordFactory. We should rely on this functionality instead. I’ll therefore close this for now. Please feel free to contact me if you think that this is the wrong decision.

    Best, Oli