#98116History rollback with mixed data
Description
When you perform a history rollback containing insert/deletes and just changed records, the rollback does only rollback insert/deletes. It does not rollback changed records.
Bug possibly introduced here: https://github.com/TYPO3/typo3/commit/2b347709fc9edcd2435698e2794562153cccfef2
Reviews 3
Related issues 1
Files 2
History 920
-
Anonymous changed Related to #81649 <span data-processor="relativetime" data-value="2022-08-10T11:29:56+00:00" > 08/10/22, 11:29 </span>
-
Gerrit Code Review pushed patch set 1 for main to change 75411 status
NewUnder Review <span data-processor="relativetime" data-value="2022-08-10T11:33:56+00:00" > 08/10/22, 11:33 </span> -
Anonymous commented <span data-processor="relativetime" data-value="2022-08-10T14:44:24+00:00" > 08/10/22, 14:44 </span>
You need to have “changed records” and (“newly inserted” or “deleted records”) in the “rollback-batch”.
Result: only insert/deletes are rolled back. The “changed” records are not rolled back.
-
Anonymous commented and changed attached image.png attached image.png <span data-processor="relativetime" data-value="2022-08-10T15:05:03+00:00" > 08/10/22, 15:05 </span>
But I can provide a (rather stupid) step by step guide:
- create page
- create “text” content element (UID: 1)
- give it a header “foo” and a subheader “bar”
- create “image” content element (UID: 2)
- assign it some image file
- create “textimage” content element (UID: 3)
- give it a header “baz” and a subheader “qux” and some image
- delete CE 1 and 2
- change “header” of UID:3 to “hello world”
Now visit page history. Show all sub-children-records.
Now revert the deletion of UID:1 & UID:2 and the header-modification on UID:3.
Do this with “rollback all changes shown”-button. Do not use the “rollback single record”-button!see image attachment https://forge.typo3.org/attachments/37027
Expected result: UID:3 “header” is “baz” again.
Actual result: UID:3 “header” remains “hello world”
see image attachment https://forge.typo3.org/attachments/37028
-
Anonymous commented <span data-processor="relativetime" data-value="2022-08-10T15:08:19+00:00" > 08/10/22, 15:08 </span>
Feel free to update the patch commit message. I had no muse.
-
Gerrit Code Review pushed patch set 2 for main to change 75411 <span data-processor="relativetime" data-value="2023-04-14T16:56:40+00:00" > 04/14/23, 16:56 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 75411 <span data-processor="relativetime" data-value="2023-04-14T17:45:29+00:00" > 04/14/23, 17:45 </span>
-
Gerrit Code Review pushed patch set 4 for main to change 75411 <span data-processor="relativetime" data-value="2023-05-03T09:46:16+00:00" > 05/03/23, 09:46 </span>
-
Gerrit Code Review pushed patch set 5 for main to change 75411 <span data-processor="relativetime" data-value="2023-08-05T07:18:48+00:00" > 08/05/23, 07:18 </span>
-
Gerrit Code Review pushed patch set 6 for main to change 75411 <span data-processor="relativetime" data-value="2023-08-07T08:55:35+00:00" > 08/07/23, 08:55 </span>
-
Gerrit Code Review pushed patch set 7 for main to change 75411 <span data-processor="relativetime" data-value="2024-10-18T13:46:47+00:00" > 10/18/24, 13:46 </span>
-
Soren Malling commented <span data-processor="relativetime" data-value="2025-03-10T08:59:25+00:00" > 03/10/25, 08:59 </span>
We are seeing the same issue in TYPO3 12.4.
We are investigating it further to really confirm both described issue and to test patch -
Soren Malling commented <span data-processor="relativetime" data-value="2025-03-26T11:40:15+00:00" > 03/26/25, 11:40 </span>
Tested on 12.4 and can confirm expected behavior with change. This should also be targeted 12.4
-
Gerrit Code Review pushed patch set 8 for main to change 75411 <span data-processor="relativetime" data-value="2025-03-26T11:45:50+00:00" > 03/26/25, 11:45 </span>
-
Gerrit Code Review pushed patch set 9 for main to change 75411 <span data-processor="relativetime" data-value="2025-03-26T11:46:00+00:00" > 03/26/25, 11:46 </span>
-
Gerrit Code Review pushed patch set 1 for 13.4 to change 88770 <span data-processor="relativetime" data-value="2025-03-26T12:38:33+00:00" > 03/26/25, 12:38 </span>
-
Gerrit Code Review pushed patch set 1 for 12.4 to change 88771 <span data-processor="relativetime" data-value="2025-03-26T12:38:39+00:00" > 03/26/25, 12:38 </span>
-
Anonymous commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2025-03-26T12:55:09+00:00" > 03/26/25, 12:55 </span>Applied in changeset commit:db7f3143efb1f50d2a3abd39c582223612bbd1df.
-
Benni Mack changed status
ResolvedClosed <span data-processor="relativetime" data-value="2025-12-02T14:33:56+00:00" > 12/02/25, 14:33 </span>
Maybe I’m too stupid, but can not reproduce this with current main. Can you please provide a step by step introduction to reproduce this (for me) ?