Issue Bug Closed

#98116History rollback with mixed data

Anonymous 08/10/22, 11:29 updated 12/02/25, 14:33

Description

When you perform a history rollback containing insert/deletes and just changed records, the rollback does only rollback insert/deletes. It does not rollback changed records.

Bug possibly introduced here: https://github.com/TYPO3/typo3/commit/2b347709fc9edcd2435698e2794562153cccfef2

Reviews 3

Files 2

History 920

  1. Stefan Bürk commented <span data-processor="relativetime" data-value="2022-08-10T14:39:06+00:00" > 08/10/22, 14:39 </span>

    Maybe I’m too stupid, but can not reproduce this with current main. Can you please provide a step by step introduction to reproduce this (for me) ?

  2. Anonymous commented <span data-processor="relativetime" data-value="2022-08-10T14:44:24+00:00" > 08/10/22, 14:44 </span>

    You need to have “changed records” and (“newly inserted” or “deleted records”) in the “rollback-batch”.

    Result: only insert/deletes are rolled back. The “changed” records are not rolled back.

  3. Anonymous commented and changed attached image.png attached image.png <span data-processor="relativetime" data-value="2022-08-10T15:05:03+00:00" > 08/10/22, 15:05 </span>

    But I can provide a (rather stupid) step by step guide:

    1. create page
    2. create “text” content element (UID: 1)
    3. give it a header “foo” and a subheader “bar”
    4. create “image” content element (UID: 2)
    5. assign it some image file
    6. create “textimage” content element (UID: 3)
    7. give it a header “baz” and a subheader “qux” and some image
    8. delete CE 1 and 2
    9. change “header” of UID:3 to “hello world”

    Now visit page history. Show all sub-children-records.
    Now revert the deletion of UID:1 & UID:2 and the header-modification on UID:3.
    Do this with “rollback all changes shown”-button. Do not use the “rollback single record”-button!

    see image attachment https://forge.typo3.org/attachments/37027

    Expected result: UID:3 “header” is “baz” again.

    Actual result: UID:3 “header” remains “hello world”

    see image attachment https://forge.typo3.org/attachments/37028

  4. Anonymous commented <span data-processor="relativetime" data-value="2022-08-10T15:08:19+00:00" > 08/10/22, 15:08 </span>

    Feel free to update the patch commit message. I had no muse.

  5. Soren Malling commented <span data-processor="relativetime" data-value="2025-03-10T08:59:25+00:00" > 03/10/25, 08:59 </span>

    We are seeing the same issue in TYPO3 12.4.
    We are investigating it further to really confirm both described issue and to test patch

  6. Soren Malling commented <span data-processor="relativetime" data-value="2025-03-26T11:40:15+00:00" > 03/26/25, 11:40 </span>

    Tested on 12.4 and can confirm expected behavior with change. This should also be targeted 12.4

  7. Anonymous commented and changed status Under Review Resolved done 0 % 100 % <span data-processor="relativetime" data-value="2025-03-26T12:55:09+00:00" > 03/26/25, 12:55 </span>

    Applied in changeset commit:db7f3143efb1f50d2a3abd39c582223612bbd1df.