Issue Bug Closed

#98202RTE removes class from hr due to processing.yaml definition

Daniel Kruse 08/25/22, 08:21 updated 08/12/25, 14:36

Description

A customer wanted to set a color to the horizontal line to change the color.
While developing i encountered the problem that the class was always removed. Debugging shows a different array for the hr-tag than for example the span, which allows at least the class.
In the typo3/sysext/rte_ckeditor/Configuration/RTE/Processing.yaml i found this special lines of code:

      hr:
        allowedAttribs:
          - class

This breaks the logic for hr-tags in typo3/sysext/core/Classes/Html/HtmlParser.php (Line 480 and following)
(btw: i’m kind of confused about the “_allowedAttribs”)

a fix provided in the attached patch-file looks like this in my custom rte yaml file:

      hr:
        allowedAttribs: class

Thanks for taking a look at my first bug report

Reviews 4

Files 1

History 511

  1. Oliver Hader commented <span data-processor="relativetime" data-value="2022-08-25T08:27:53+00:00" > 08/25/22, 08:27 </span>

    I was working on a patch months ago. The main problem is, that the RTE fails to handle these declarations correctly. In legacy code those were just strings, since TYPO3 v8 and having CKEditor4 in place, that was extended to array items as well – however, both still need to be supported.

    However, currently array item declarations are not fully supported…
    see https://review.typo3.org/c/Packages/TYPO3.CMS/+/74498

  2. Garvin Hicking commented <span data-processor="relativetime" data-value="2024-10-22T11:57:09+00:00" > 10/22/24, 11:57 </span>

    Please note that at the time of this writing, CKEditor5 does NOT allow styling on hr tags: https://github.com/ckeditor/ckeditor5/issues/12973

  3. Eric Harrer commented and changed status Under Review Resolved done 0 % 100 % <span data-processor="relativetime" data-value="2025-03-25T09:55:08+00:00" > 03/25/25, 09:55 </span>

    Applied in changeset commit:48673310321c42c99f54cd6a02058307c0d105fe.