Review main Merged

13021[TASK] Improve sys_note code

Georg Ringer CR +2 V +2 Normal +172 −74 updated 06/03/13, 20:49

Commit message

Code of sys_note can be highly improved:
* Use fluid
* Move xlf files to Resources
* Add kind-of repository

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 9

Review log 23

  1. Marcus Schwemer uploaded patch set 2 07/29/12, 14:46

  2. Marcus Schwemer commented on patch set 2 07/29/12, 14:46

    Verified; Looks good to me, but someone else must approve Tried to resolve the inline comments. Not sure about Olli's guard clause. If you want I will revert it. Cheers Marcus
  3. Marcus Schwemer uploaded patch set 3 07/29/12, 14:46

  4. Oliver Klee commented on patch set 1 4 comments 07/29/12, 14:46

    Looks good to me, but someone else must approve
  5. Georg Ringer commented on patch set 3 07/29/12, 14:46

    Verified; Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 1 07/29/12, 14:46

  7. Mr. Jenkins commented on patch set 2 07/29/12, 14:46

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/5031/ : FAILURE
  8. Mr. Jenkins commented on patch set 3 07/29/12, 14:46

  9. Wouter Wolters commented on patch set 1 07/29/12, 14:46

    Looks good to me, but someone else must approve Looks good

    SysNoteRepository.php:51

    space after foreach

    SysNote.php:63

    array
  10. Christian Kuhn commented on patch set 4 07/29/12, 14:46

    Fails -1 on testing: edit icon on notes in page overview is broken (wrong path to alt_doc.php)
  11. Christian Kuhn commented on patch set 5 07/29/12, 14:46

    (1 inline comment)
  12. Christian Kuhn uploaded patch set 6 07/29/12, 14:46

  13. Christian Kuhn commented on patch set 6 07/29/12, 14:46

    Verified; Looks good to me, but someone else must approve
  14. Georg Ringer uploaded patch set 5 07/29/12, 14:46

  15. Mr. Jenkins commented on patch set 4 07/29/12, 14:46

  16. Mr. Jenkins commented on patch set 5 07/29/12, 14:46

  17. Mr. Jenkins commented on patch set 6 07/29/12, 14:46

  18. Wouter Wolters uploaded patch set 4 07/29/12, 14:46

  19. Wouter Wolters commented on patch set 4 07/29/12, 14:46

    Verified; Looks good to me, but someone else must approve
  20. Wouter Wolters commented on patch set 5 1 comment 07/29/12, 14:46

    Verified; Looks good to me, but someone else must approve One small CGL thing, can be changed on commit IMO
  21. Wouter Wolters commented on patch set 6 07/29/12, 14:46

    Verified; Looks good to me, but someone else must approve
  22. Christian Kuhn commented on patch set 6 V 0 07/29/12, 14:46

    by team member; Looks good to me, approved
  23. Christian Kuhn merged patch set 6 07/29/12, 14:46