13021[TASK] Improve sys_note code
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
-
Verified V +2
- Christian Kuhn +2
- Wouter Wolters +1
Issues 1
Files 9
- typo3/sysext/sys_note/Classes/Domain/Repository/SysNoteRepository.php4new+60 −0
- typo3/sysext/sys_note/Classes/ViewHelpers/EditLinkViewHelper.phpnew+44 −0
- typo3/sysext/sys_note/Classes/SysNote.php3+25 −65
- typo3/sysext/sys_note/Configuration/Tca/SysNote.php+7 −7
- typo3/sysext/sys_note/Resources/Private/Language/locallang.xlfrenamed+0 −0
- typo3/sysext/sys_note/Resources/Private/Language/locallang_csh_sysnote.xlfrenamed+0 −0
- typo3/sysext/sys_note/Resources/Private/Language/locallang_tca.xlfrenamed+0 −0
- typo3/sysext/sys_note/Resources/Private/Template/List.htmlnew+34 −0
- typo3/sysext/sys_note/ext_tables.php+2 −2
Review log 23
-
Marcus Schwemer uploaded patch set 2 07/29/12, 14:46
-
Marcus Schwemer commented on patch set 2 07/29/12, 14:46
Verified; Looks good to me, but someone else must approve Tried to resolve the inline comments. Not sure about Olli's guard clause. If you want I will revert it. Cheers Marcus -
Marcus Schwemer uploaded patch set 3 07/29/12, 14:46
-
Oliver Klee commented on patch set 1 4 comments 07/29/12, 14:46
Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 3 07/29/12, 14:46
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 07/29/12, 14:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4996/ : SUCCESS -
Mr. Jenkins commented on patch set 2 07/29/12, 14:46
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/5031/ : FAILURE -
Mr. Jenkins commented on patch set 3 07/29/12, 14:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5032/ : SUCCESS -
Wouter Wolters commented on patch set 1 07/29/12, 14:46
Looks good to me, but someone else must approve Looks goodSysNoteRepository.php:51space after foreachSysNote.php:63array -
Christian Kuhn commented on patch set 4 07/29/12, 14:46
Fails -1 on testing: edit icon on notes in page overview is broken (wrong path to alt_doc.php) -
Christian Kuhn commented on patch set 5 07/29/12, 14:46
(1 inline comment) -
Christian Kuhn uploaded patch set 6 07/29/12, 14:46
-
Christian Kuhn commented on patch set 6 07/29/12, 14:46
Verified; Looks good to me, but someone else must approve -
Georg Ringer uploaded patch set 5 07/29/12, 14:46
-
Mr. Jenkins commented on patch set 4 07/29/12, 14:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5042/ : SUCCESS -
Mr. Jenkins commented on patch set 5 07/29/12, 14:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5053/ : SUCCESS -
Mr. Jenkins commented on patch set 6 07/29/12, 14:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/5065/ : SUCCESS -
Wouter Wolters uploaded patch set 4 07/29/12, 14:46
-
Wouter Wolters commented on patch set 4 07/29/12, 14:46
Verified; Looks good to me, but someone else must approve -
Wouter Wolters commented on patch set 5 1 comment 07/29/12, 14:46
Verified; Looks good to me, but someone else must approve One small CGL thing, can be changed on commit IMO -
Wouter Wolters commented on patch set 6 07/29/12, 14:46
Verified; Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 6 V 0 07/29/12, 14:46
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 6 07/29/12, 14:46