Review main Merged

14291[BUGFIX] Warning in ConfigurationManagerTest

Christian Kuhn CR +2 V +2 Normal +182 −54 updated 06/03/13, 20:49

Commit message

Fix setLocalConfigurationValueByPathReturnFalseIfPathIsNotValid that
calls setLocalConfigurationValueByPath() without a second value and
raises a warning.
Additionally, the test eval's are formatted again to be easy readable.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 1

Review log 5

  1. Christian Kuhn uploaded patch set 2 09/02/12, 14:35

  2. Christian Kuhn commented on patch set 2 V 0 09/02/12, 14:35

    by team member; Looks good to me, approved
  3. Mr. Jenkins commented on patch set 1 09/02/12, 14:35

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/5665/ : FAILURE
  4. Mr. Jenkins commented on patch set 2 09/02/12, 14:35

  5. Christian Kuhn merged patch set 2 09/02/12, 14:35