Review main Merged

15837[BUGFIX] Images from non-local storages are not displayed

Andreas Wolf CR +2 V +2 Easy +8 −3 updated 06/03/13, 20:49

Commit message

The content object renderer adds absRefPrefix to all
generated image URLs, leading to incorrect URLs for
storages not relative to the siteroot. Additionally,
the URLs generated by the driver are also escaped in
ContentObjectRenderer::cImage(), leading to broken
absolute URLs.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Alexander Opitz +1
    • Nicole Hummel +1
  • Verified V +2
    • Steffen Ritter +2
    • Nicole Hummel +1

Issues 1

Files 1

Review log 27

Show 2 earlier messages
  1. Andreas Wolf uploaded patch set 2 04/07/13, 10:35

  2. Steffen Ritter commented on patch set 2 04/07/13, 10:35

    Fails; Do not submit $GLOBALS['TSFE']->absRefPrefix? with //todo check in backend? what is to check? this WILL fail without additional check absrefprefix has nothing to do with the FAL API itself - the place of cImage is the correct place for that resolval therefore -2 to the idea itself
  1. Andreas Wolf commented on patch set 3 04/07/13, 10:35

    Looks good to me, but someone else must approve
  2. Andreas Wolf uploaded patch set 4 04/07/13, 10:35

  3. Andreas Wolf uploaded patch set 5 04/07/13, 10:35

  4. Andreas Wolf uploaded patch set 6 04/07/13, 10:35

  5. Steffen Ritter uploaded patch set 3 04/07/13, 10:35

  6. Steffen Ritter commented on patch set 3 04/07/13, 10:35

    No score
  7. Steffen Ritter uploaded patch set 7 04/07/13, 10:35

  8. Andreas Wolf uploaded patch set 9 04/07/13, 10:35

  9. Andreas Wolf commented on patch set 9 04/07/13, 10:35

    Rebased again
  10. Alexander Opitz commented on patch set 9 04/07/13, 10:35

    Looks good to me, but someone else must approve
  11. Georg Ringer commented on patch set 8 04/07/13, 10:35

    are you sure you wanna change fluid?!
  12. Steffen Ritter commented on patch set 8 04/07/13, 10:35

    damn submodules, we should drop them as soon as we have composer support! for sure not.
  13. Steffen Ritter uploaded patch set 8 04/07/13, 10:35

  14. Steffen Ritter commented on patch set 8 04/07/13, 10:35

    just rebased
  15. Steffen Ritter commented on patch set 9 V 0 04/07/13, 10:35

    by team member; Looks good to me, approved
  16. Steffen Ritter commented on patch set 9 04/07/13, 10:35

    Verified; Looks good to me, but someone else must approve
  17. Mr. Jenkins commented on patch set 1 04/07/13, 10:35

  18. Mr. Jenkins commented on patch set 2 04/07/13, 10:35

  19. Mr. Jenkins commented on patch set 3 04/07/13, 10:35

  20. Mr. Jenkins commented on patch set 5 04/07/13, 10:35

  21. Mr. Jenkins commented on patch set 6 04/07/13, 10:35

  22. Mr. Jenkins commented on patch set 8 04/07/13, 10:35

  23. Mr. Jenkins commented on patch set 9 04/07/13, 10:35

  24. Nicole Hummel commented on patch set 9 04/07/13, 10:35

    Verified; Looks good to me, but someone else must approve
  25. Steffen Ritter merged patch set 10 04/07/13, 10:35