15837[BUGFIX] Images from non-local storages are not displayed
Commit message
Review
-
Code review CR +2
- Steffen Ritter +2
- Alexander Opitz +1
- Nicole Hummel +1
-
Verified V +2
- Steffen Ritter +2
- Nicole Hummel +1
Issues 1
Files 1
Review log 27
Show 2 earlier messages
-
Andreas Wolf uploaded patch set 2 04/07/13, 10:35
-
Steffen Ritter commented on patch set 2 04/07/13, 10:35
Fails; Do not submit $GLOBALS['TSFE']->absRefPrefix? with //todo check in backend? what is to check? this WILL fail without additional check absrefprefix has nothing to do with the FAL API itself - the place of cImage is the correct place for that resolval therefore -2 to the idea itself
-
Andreas Wolf commented on patch set 3 04/07/13, 10:35
Looks good to me, but someone else must approve -
Andreas Wolf uploaded patch set 4 04/07/13, 10:35
-
Andreas Wolf uploaded patch set 5 04/07/13, 10:35
-
Andreas Wolf uploaded patch set 6 04/07/13, 10:35
-
Steffen Ritter uploaded patch set 3 04/07/13, 10:35
-
Steffen Ritter commented on patch set 3 04/07/13, 10:35
No score -
Steffen Ritter uploaded patch set 7 04/07/13, 10:35
-
Andreas Wolf uploaded patch set 9 04/07/13, 10:35
-
Andreas Wolf commented on patch set 9 04/07/13, 10:35
Rebased again -
Alexander Opitz commented on patch set 9 04/07/13, 10:35
Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 8 04/07/13, 10:35
are you sure you wanna change fluid?! -
Steffen Ritter commented on patch set 8 04/07/13, 10:35
damn submodules, we should drop them as soon as we have composer support! for sure not. -
Steffen Ritter uploaded patch set 8 04/07/13, 10:35
-
Steffen Ritter commented on patch set 8 04/07/13, 10:35
just rebased -
Steffen Ritter commented on patch set 9 V 0 04/07/13, 10:35
by team member; Looks good to me, approved -
Steffen Ritter commented on patch set 9 04/07/13, 10:35
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 04/07/13, 10:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6363/ : SUCCESS -
Mr. Jenkins commented on patch set 2 04/07/13, 10:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6390/ : SUCCESS -
Mr. Jenkins commented on patch set 3 04/07/13, 10:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6393/ : SUCCESS -
Mr. Jenkins commented on patch set 5 04/07/13, 10:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6669/ : SUCCESS -
Mr. Jenkins commented on patch set 6 04/07/13, 10:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6671/ : SUCCESS -
Mr. Jenkins commented on patch set 8 04/07/13, 10:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6795/ : SUCCESS -
Mr. Jenkins commented on patch set 9 04/07/13, 10:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7428/ : SUCCESS -
Nicole Hummel commented on patch set 9 04/07/13, 10:35
Verified; Looks good to me, but someone else must approve -
Steffen Ritter merged patch set 10 04/07/13, 10:35