19204[BUGFIX] Error in filelist for Storage context menu
Commit message
Review
-
Code review CR +2
- Andreas Wolf +2
-
Verified V +2
- Andreas Wolf +2
Issues 1
Files 3
Review log 14
-
Andreas Wolf uploaded patch set 2 03/24/13, 10:25
-
Andreas Wolf uploaded patch set 3 03/24/13, 10:25
-
Andreas Wolf uploaded patch set 4 03/24/13, 10:25
-
Andreas Wolf commented on patch set 4 V 0 03/24/13, 10:25
by team member; Looks good to me, approved Just reworded the commit message (Benni, Nicole and I agreed that this is not a feature, but fixes a crash and thus a serious bug). -
Tom commented on patch set 3 03/24/13, 10:25
Looks good to me, but someone else must approve -
Alexander Opitz commented on patch set 1 03/24/13, 10:25
Fails; Looks good to me, but someone else must approveClickMenu.php:758This should be $isOnline = FALSE; -
Alexander Opitz commented on patch set 3 03/24/13, 10:25
Verified; Looks good to me, but someone else must approve -
Felix Nagel commented on patch set 3 03/24/13, 10:25
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 03/24/13, 10:25
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7886/ : SUCCESS -
Mr. Jenkins commented on patch set 2 03/24/13, 10:25
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7919/ : FAILURE -
Mr. Jenkins commented on patch set 3 03/24/13, 10:25
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7920/ : SUCCESS -
Mr. Jenkins commented on patch set 4 03/24/13, 10:25
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7931/ : SUCCESS -
Nicole Hummel commented on patch set 3 03/24/13, 10:25
Verified; Looks good to me, but someone else must approveClickMenu.php:744Remove namespace as it is injected -
Andreas Wolf merged patch set 5 03/24/13, 10:25